FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add typing.Self by starpit · Pull Request #5710 · RustPython/RustPython · GitHub

feat: add typing.Self - #5710

Closed
starpit wants to merge 1 commit into
RustPython:mainfrom
starpit:typing-self
Closed

feat: add typing.Self#5710
starpit wants to merge 1 commit into
RustPython:mainfrom
starpit:typing-self

Conversation

starpit commented Apr 17, 2025

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

Probably a good temporary fix.

See also: #5590

youknowone commented Apr 18, 2025
edited
Loading

Copy link
Copy Markdown
Member

Since test_typing does not currently cover Self, please add a small test under extra_tests/snippets/stdlib_typing.py

starpit commented Apr 18, 2025

Copy link
Copy Markdown
Author

thanks for the feedback. i agree that #5590 is a much better approach. in our case, Self is just one of many typing blockers...

Copy link
Copy Markdown
Member

@starpit #5590 will take more time. I am going to merge this one first if you don't mind to add a test about this patch.

starpit commented Apr 19, 2025
edited
Loading

Copy link
Copy Markdown
Author

fyi, #5711 is another blocker we ran into re: typing. Curious: is there some way we could offer to disable type checking?

Signed-off-by: Nick Mitchell <nickm@us.ibm.com>

starpit commented Apr 19, 2025

Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Contributor

Closing, since other PR was merged.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL