FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lzma implementation by arihant2math · Pull Request #5717 · RustPython/RustPython · GitHub

/ RustPython Public

lzma implementation - #5717

Merged
youknowone merged 6 commits into
RustPython:mainfrom
arihant2math:lzma
May 7, 2025
ConversationCommits (6)ChecksFiles changed
Merged

lzma implementation#5717
youknowone merged 6 commits into
RustPython:mainfrom
arihant2math:lzma

Conversation

arihant2math commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Based on #5709 because of the zlib abstraction.

arihant2math mentioned this pull request Apr 20, 2025
Merged
arihant2math marked this pull request as ready for review April 20, 2025 05:48

arihant2math commented Apr 20, 2025

Copy link
Copy Markdown
Contributor Author

This turned out surprisingly effective, about 2/3s of the tests pass, which is enough for me at the moment. The main missing parts involve a bunch of unsafe things that xz2 doesn't really support (to my knowledge atleast).

As a side note I also abstracted out Compressor like Decompressor was abstracted

arihant2math force-pushed the lzma branch 2 times, most recently from c09442c to 2bad5d2 Compare April 21, 2025 00:01
arihant2math marked this pull request as draft April 21, 2025 02:24
arihant2math marked this pull request as ready for review April 21, 2025 02:24

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

Lots of tests are failing because they were previously blocked due to no implementation at all.

arihant2math changed the title Lzma implementation lzma implementation Apr 21, 2025
coolreader18 mentioned this pull request Apr 21, 2025
Merged

coolreader18 commented Apr 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Would you be able to squash these commits down? Ideally into one for copying the files from cpython, and one for all the rest?

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

Sure

arihant2math force-pushed the lzma branch 3 times, most recently from 19a43f5 to ca2dc44 Compare April 21, 2025 19:40

arihant2math commented Apr 21, 2025

Copy link
Copy Markdown
Contributor Author

It's at 3 now, I committed things in a weird fashion so I can't get it below that.

arihant2math mentioned this pull request Apr 23, 2025
Closed
arihant2math requested a review from youknowone April 27, 2025 06:47
youknowone reviewed Apr 30, 2025
View reviewed changes
Comment thread Lib/tarfile.py Outdated
elif comptype == "xz":
try:
import lzma
# TODO: RUSTPYTHON remove underscore

youknowone Apr 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this name changed to raise ImportError? What happens if it is lzma?

arihant2math Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, if left as is everything breaks because lzma is expected to be unimportable.

youknowone May 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

xz seems to be not support. Added reason and avoided to use fake module name

youknowone commented May 6, 2025

Copy link
Copy Markdown
Member

oh no.. I thought #5728 and this one had shared work of the new compression module

youknowone commented May 6, 2025

Copy link
Copy Markdown
Member

@arihant2math What will be the best way? Is it worth to keep #5728?
if yes, the conflict need to be resolve.
if not, reverting it and merging this can be a way.

arihant2math commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

Probably easiest to revert, yes.

youknowone and others added 3 commits May 7, 2025 15:01
Revert "Split out common compression routines into separate file (Rus…
48b08a2 
…tPython#5728)"

This reverts commit 9c88475.
add _lzma module with new dependency
2a1ea45 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
add lzma.py and test_lzma.py at 3.13.2
2042d87 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
arihant2math and others added 2 commits May 7, 2025 15:01
youknowone merged commit 79646fd into RustPython:main May 7, 2025
arihant2math deleted the lzma branch May 7, 2025 16:47
youknowone mentioned this pull request Dec 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes
coolreader18 Awaiting requested review from coolreader18

Assignees

No one assigned

Labels

A-stdlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL