FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix stable clippy by youknowone · Pull Request #5843 · RustPython/RustPython · GitHub

/ RustPython Public

Fix stable clippy - #5843

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-clippy
Jun 27, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Fix stable clippy#5843
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-clippy

Conversation

youknowone commented Jun 27, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Updated string formatting throughout the application to use modern named parameter syntax, improving code readability and consistency. No changes to functionality or output.
  • Chores
    • Refined error and panic message formatting for clarity without altering behavior.
    • Added a dependency override for the radium crate to source from a specific Git repository and branch.

coderabbitai Bot commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update string formatting throughout several modules, replacing positional formatting in Rust's format!, write!, and panic! macros with the newer named argument syntax. Additionally, a type cast in TryFrom<WideChar> for CodePoint was slightly modified, and a dependency override was added to a Cargo.toml file. No logic or control flow is altered; only the style of string interpolation and dependency sourcing is modernized or clarified.

Changes

File(s) Change Summary
stdlib/src/array.rs Changed type cast in TryFrom<WideChar> for CodePoint from as u32 to as _.
vm/src/builtins/genericalias.rs Simplified error message formatting in subs_parameters using inline named formatting syntax.
vm/src/frame.rs Updated multiple format! calls to use named arguments for string formatting.
vm/src/stdlib/functools.rs Converted all format! calls in repr_str to use named formatting syntax.
vm/src/stdlib/sys.rs Updated error message and output formatting in excepthook to use named arguments.
vm/src/stdlib/typing.rs Modernized all repr_str implementations to use named/inlined variable formatting.
vm/src/vm/vm_object.rs Changed panic message formatting to use inline variable interpolation in two wasm32 code branches.
jit/tests/common.rs Changed panic message formatting in get_function to use inline named formatting.
benches/execution.rs Changed string formatting in benchmark_pystone to use named placeholders.
compiler/literal/src/float.rs Updated assertion message formatting in test_to_hex to use named placeholders.
examples/dis.rs Changed error logging formatting to use inline named arguments.
examples/parse_folder.rs Updated all log macro calls to use inline named formatting for variables.
wasm/wasm-unknown-test/Cargo.toml Added [patch.crates-io] section to override radium crate source to a specific Git repo and branch.

Suggested reviewers

  • arihant2math

Poem

Rusty strings now shine anew,
With curly braces, names peek through.
No more numbers, just a name—
Formatting’s never quite the same!
The code hops forward, clean and bright,
A rabbit’s joy at every byte.
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a2da9f and 6c561ac.

📒 Files selected for processing (13)
  • benches/execution.rs (1 hunks)
  • compiler/literal/src/float.rs (1 hunks)
  • examples/dis.rs (1 hunks)
  • examples/parse_folder.rs (3 hunks)
  • jit/tests/common.rs (1 hunks)
  • stdlib/src/array.rs (1 hunks)
  • vm/src/builtins/genericalias.rs (1 hunks)
  • vm/src/frame.rs (4 hunks)
  • vm/src/stdlib/functools.rs (2 hunks)
  • vm/src/stdlib/sys.rs (1 hunks)
  • vm/src/stdlib/typing.rs (4 hunks)
  • vm/src/vm/vm_object.rs (2 hunks)
  • wasm/wasm-unknown-test/Cargo.toml (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share 🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai Bot reviewed Jun 27, 2025
View reviewed changes

coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d492a6 and 13e33b6.

📒 Files selected for processing (7)
  • stdlib/src/array.rs (1 hunks)
  • vm/src/builtins/genericalias.rs (1 hunks)
  • vm/src/frame.rs (4 hunks)
  • vm/src/stdlib/functools.rs (2 hunks)
  • vm/src/stdlib/sys.rs (1 hunks)
  • vm/src/stdlib/typing.rs (4 hunks)
  • vm/src/vm/vm_object.rs (2 hunks)
🧰 Additional context used 🧠 Learnings (4) 📓 Common learnings 
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Minimize modifications to CPython standard library files in the Lib/ directory; bug fixes should be made through Rust code modifications whenever possible.
vm/src/vm/vm_object.rs (3) 
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Minimize modifications to CPython standard library files in the Lib/ directory; bug fixes should be made through Rust code modifications whenever possible.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Follow Rust best practices for error handling and memory management in all RustPython Rust code.

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.
vm/src/stdlib/sys.rs (1) 
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Follow Rust best practices for error handling and memory management in all RustPython Rust code.
vm/src/stdlib/typing.rs (1) 
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (10)
vm/src/builtins/genericalias.rs (1)

391-393: LGTM: Modernized string formatting syntax.

The inline formatting {idx} is more concise and readable than the previous multi-line approach. This follows modern Rust idioms and addresses clippy suggestions.

stdlib/src/array.rs (1)

604-604: LGTM: Improved type casting with inference.

Using as _ allows the compiler to infer the target type from the function signature, making the code more concise while maintaining the same functionality. This addresses clippy's suggestion for unnecessary explicit type annotation.

vm/src/stdlib/typing.rs (3)

174-178: LGTM: Modernized TypeVar representation formatting.

The inline variable formatting ({name}) is more readable and concise than the previous positional argument style. This follows modern Rust formatting conventions while maintaining identical functionality.

741-741: LGTM: Improved TypeVarTuple formatting.

Using inline variable formatting improves readability and follows modern Rust idioms.

788-788: LGTM: Consistent ParamSpec formatting improvements.

Both ParamSpecArgs and ParamSpecKwargs now use the modern inline variable formatting syntax, making the code more consistent and readable across the typing module.

Also applies to: 867-867

vm/src/vm/vm_object.rs (1)

23-23: LGTM! String formatting modernized correctly.

The panic messages have been appropriately updated to use inline variable interpolation syntax instead of positional formatting. This improves readability and addresses clippy warnings while maintaining identical functionality.

Also applies to: 41-41, 52-52

vm/src/stdlib/sys.rs (1)

375-379: LGTM! Exception error formatting modernized.

The error message formatting has been correctly updated to use named parameter syntax. The {type_name} placeholder and {msg} interpolation improve code clarity while maintaining the same error output behavior.

vm/src/stdlib/functools.rs (1)

289-292: LGTM! Repr formatting modernized with named parameters.

The repr_str method's string formatting has been appropriately updated to use named parameter syntax throughout. This improves code readability in the complex repr construction logic while maintaining identical output formatting.

Also applies to: 312-312, 319-322

vm/src/frame.rs (2)

352-355: OK – purely stylistic change

The switch to named-argument formatting is correct and keeps behaviour intact.

1650-1651: Looks good – safer & clearer mapping validation

Using the named-argument style keeps the message intact and improves readability.

Comment thread vm/src/frame.rs Outdated
Comment thread vm/src/frame.rs Outdated
youknowone force-pushed the fix-clippy branch 2 times, most recently from 0cfb19f to 5a2da9f Compare June 27, 2025 03:02
youknowone merged commit fe2c9bf into RustPython:main Jun 27, 2025
youknowone deleted the fix-clippy branch June 27, 2025 03:12
coderabbitai Bot mentioned this pull request Sep 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL