FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update `warnings` from 3.13.5 by ShaharNaveh · Pull Request #6019 · RustPython/RustPython · GitHub

/ RustPython Public

Update warnings from 3.13.5 - #6019

Merged
youknowone merged 3 commits into
RustPython:mainfrom
ShaharNaveh:update-warning
Jul 23, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Update warnings from 3.13.5#6019
youknowone merged 3 commits into
RustPython:mainfrom
ShaharNaveh:update-warning

Conversation

ShaharNaveh commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

ShaharNaveh marked this pull request as draft July 22, 2025 12:53
ShaharNaveh changed the title Update warnings Update warnings from 3.13.5 Jul 22, 2025

coderabbitai Bot commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (6)
  • Lib/test/test_warnings/__init__.py is excluded by !Lib/**
  • Lib/test/test_warnings/__main__.py is excluded by !Lib/**
  • Lib/test/test_warnings/data/import_warning.py is excluded by !Lib/**
  • Lib/test/test_warnings/data/package_helper.py is excluded by !Lib/**
  • Lib/test/test_warnings/data/stacklevel.py is excluded by !Lib/**
  • Lib/warnings.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share 🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

ShaharNaveh commented Jul 22, 2025
View reviewed changes
Comment thread Lib/test/test_warnings/__init__.py

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_default_filter_configuration(self):

ShaharNaveh Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@youknowone This test fails here, in the parent test class. but it passes when it runs with the python test class
PyEnvironmentVariableTests

How should I mark the parent as failing but the child as passing?

ShaharNaveh marked this pull request as ready for review July 22, 2025 13:37

ShaharNaveh commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

Can't believe I missread that and tried to mark the root class instead of the child only. Thanks!

youknowone approved these changes Jul 23, 2025
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That sometimes happens. 😂 Thanks!

youknowone merged commit 9995cc6 into RustPython:main Jul 23, 2025
12 checks passed
ShaharNaveh deleted the update-warning branch July 23, 2025 08:58
youknowone mentioned this pull request Dec 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL