Actionable comments posted: 0

🧹 Nitpick comments (3)

src/shell.rs (3)

77-81: Refresh the comment to match the actual behavior and remove stale ‘dedent’ note

The current comment mentions column checks and dedent handling that aren’t reflected in the code anymore. Updating the comment helps future maintainers.

Apply this diff to align the comment with the current logic:

-            // bad_error == true if we are handling an error that should be thrown even if we are continuing
-            // if its an indentation error, set to true if we are continuing and the error is on column 0,
-            // since indentations errors on columns other than 0 should be ignored.
-            // if its an unrecognized token for dedent, set to false
+            // bad_error is true when the error should be raised immediately (fatal), even while building a block.
+            // - IndentationError: fatal iff we are already continuing a block (pressing an empty line still raises).
+            // - "Expected an indented block": non-fatal — always ContinueBlock to allow nested/nested blocks.
+            // - All other parse errors: fatal.

---

82-95: Avoid brittle string literal; centralize the prefix used for detection

To reduce the risk of typos and make future updates easier if the message text changes slightly, centralize the prefix in a constant and reference it here.

Apply this diff within this match arm:

-                        ParseErrorType::OtherError(msg) => {
-                            !msg.starts_with("Expected an indented block")
-                        }
+                        ParseErrorType::OtherError(msg) => {
+                            !msg.starts_with(EXPECTED_INDENTED_BLOCK_PREFIX)
+                        }

Add this constant near the top of the file (e.g., after imports):

const EXPECTED_INDENTED_BLOCK_PREFIX: &str = "Expected an indented block";

---

97-103: Add targeted tests to lock in behavior (nested blocks and blank-line error)

The new behavior is desirable; please add tests that assert:

• ContinueBlock after a single “for …:” line.
• ContinueBlock after a nested “for …:” line when already in a continuing block.
• PyErr when an empty line is submitted while still expecting an indented block (matches CPython).

I can help scaffold tests around shell_exec in a #[cfg(test)] module to exercise these cases.

Would you like me to draft the tests?

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9a9e3b and 135ccae.

📒 Files selected for processing (1)

• src/shell.rs (1 hunks)

🧰 Additional context used 📓 Path-based instructions (1) **/*.rs

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

• src/shell.rs

🔇 Additional comments (2)

src/shell.rs (2)

88-90: Always ContinueBlock on “Expected an indented block” — correct fix to enable nested blocks

This change ensures nested for/if blocks are accepted even when already inside a continuing block. The blank-line case still raises (due to the empty_line_given check), which matches CPython REPL behavior.

---

88-90: Update error-check prefix to match parser output

The guard in src/shell.rs is using the truncated prefix "Expected an indented block", but the parser emits "Expected an indented block after". This mismatch causes the intended errors to slip through.

• src/shell.rs:89

-   !msg.starts_with("Expected an indented block")
+   !msg.starts_with("Expected an indented block after")

Likely an incorrect or invalid review comment.

Thank you!

If you are interested in, This error probably be introduced in commit a6b4ef7