Actionable comments posted: 0

compiler/codegen/Cargo.toml (1)

34-34: Remove redundant dev-dependency on ruff_python_parser

It’s already a normal dependency due to compile-time usage; duplicating it in dev-deps is unnecessary.

 [dev-dependencies]
-ruff_python_parser = { workspace = true }
 insta = { workspace = true }

compiler/codegen/src/compile.rs (2)

150-162: Avoid reparsing for every unparse and stabilize line endings

Unconditionally reparsing "x = 1" on every call is unnecessary. Cache the computed indentation with OnceLock and force LF for reproducible output across platforms.

-fn unparse_expr(expr: &Expr) -> String {
-    // Hack, because we can't do `ruff_python_codegen::Indentation::default()`
-    // https://github.com/astral-sh/ruff/pull/20216
-    let indentation = {
-        let contents = r"x = 1";
-        let module = ruff_python_parser::parse_module(contents).unwrap();
-        let stylist = ruff_python_codegen::Stylist::from_tokens(module.tokens(), contents);
-        stylist.indentation().clone()
-    };
-
-    ruff_python_codegen::Generator::new(&indentation, LineEnding::default()).expr(expr)
-}
+fn unparse_expr(expr: &Expr) -> String {
+    static INDENT: std::sync::OnceLock<ruff_python_codegen::Indentation> =
+        std::sync::OnceLock::new();
+    let indentation = INDENT.get_or_init(|| {
+        // Hack, until Indentation::default() is available (see ruff PR #20216)
+        let contents = "x = 1";
+        let module = ruff_python_parser::parse_module(contents)
+            .expect("parse_module('x = 1') should never fail");
+        let stylist = ruff_python_codegen::Stylist::from_tokens(module.tokens(), contents);
+        stylist.indentation().clone()
+    });
+    ruff_python_codegen::Generator::new(indentation, LineEnding::Lf).expr(expr)
+}

---

3608-3616: Duplicate-key detection now relies on Ruff unparse; add coverage for semantic equivalence

Switching to Ruff’s generator likely normalizes literals (e.g., 1_0 vs 10, different string quotes). Please add/adjust tests to ensure duplicates are rejected based on semantic equality, not just textual quirks.

Would you like me to add regression tests covering numbers with underscores, different string quote styles, and mixed-case hex literals?

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Reviewing files that changed from the base of the PR and between 056795e and 87dd525.

• Cargo.lock is excluded by !**/*.lock
• Lib/test/test_future_stmt/badsyntax_future.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future3.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future4.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future5.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future6.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future7.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future8.py is excluded by !Lib/**
• Lib/test/test_future_stmt/badsyntax_future9.py is excluded by !Lib/**
• Lib/test/test_future_stmt/import_nested_scope_twice.py is excluded by !Lib/**
• Lib/test/test_future_stmt/nested_scope.py is excluded by !Lib/**
• Lib/test/test_future_stmt/test_future.py is excluded by !Lib/**

• Cargo.toml (1 hunks)
• compiler/codegen/Cargo.toml (1 hunks)
• compiler/codegen/src/compile.rs (4 hunks)
• compiler/codegen/src/lib.rs (0 hunks)
• compiler/codegen/src/unparse.rs (0 hunks)

• compiler/codegen/src/lib.rs
• compiler/codegen/src/unparse.rs

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

• compiler/codegen/src/compile.rs

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-19T03:16:56.511Z
Learning: Applies to **/*.py : Use ruff for linting Python code

Applied to files:

• Cargo.toml
• compiler/codegen/Cargo.toml

• GitHub Check: Run snippets and cpython tests (windows-latest)
• GitHub Check: Run snippets and cpython tests on wasm-wasi
• GitHub Check: Check the WASM package and demo
• GitHub Check: Check Rust code with rustfmt and clippy
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Run rust tests (macos-latest)
• GitHub Check: Run rust tests (ubuntu-latest)
• GitHub Check: Run snippets and cpython tests (macos-latest)
• GitHub Check: Run rust tests (windows-latest)
• GitHub Check: Ensure compilation on various targets

compiler/codegen/Cargo.toml (1)

16-18: Ruff parser/codegen/source_file deps: LGTM

These additions align with the new unparse path in compile.rs.

Cargo.toml (1)

165-165: Workspace adds ruff_python_codegen: LGTM

Keeps all ruff crates pinned to the same tag; good for API coherence.

compiler/codegen/src/compile.rs (2)

33-33: Import of LineEnding: LGTM

Needed for Generator construction.

---

4160-4163: Future annotations stringification parity

Using Ruff for annotation strings is fine; please verify parity with CPython across edge cases (unions, generics, nested subscripts, parentheses, and starred PEP 646 forms) to avoid subtle mismatches in annotations.

I can draft insta tests comparing against CPython’s unparse for a corpus of annotations if helpful.

Less code, no regression. Great!