FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix broken CI on windows by ShaharNaveh · Pull Request #6143 · RustPython/RustPython · GitHub

/ RustPython Public

Fix broken CI on windows - #6143

Merged
youknowone merged 8 commits into
RustPython:mainfrom
ShaharNaveh:fix-ci
Sep 11, 2025
ConversationCommits (8)ChecksFiles changed
Merged

Fix broken CI on windows#6143
youknowone merged 8 commits into
RustPython:mainfrom
ShaharNaveh:fix-ci

Conversation

ShaharNaveh commented Sep 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Recently our CI for windows started to fail. I ain't sure what's the root cause of it but it seems like it has to do with anything related to symlinks.

Anyway, this PR aims to mark the tests appropriately. I didn't update those tests to CPython 3.13.7 so we will have a clearer diff & can revert in case there's a deeper root cause that needs to be addressed

coderabbitai Bot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)
  • Lib/test/test_dtrace.py is excluded by !Lib/**
  • Lib/test/test_genericpath.py is excluded by !Lib/**
  • Lib/test/test_ntpath.py is excluded by !Lib/**
  • Lib/test/test_py_compile.py is excluded by !Lib/**
  • Lib/test/test_shutil.py is excluded by !Lib/**
  • Lib/test/test_stat.py is excluded by !Lib/**
  • Lib/test/test_tarfile.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches 🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ShaharNaveh commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Alright, I did a bit of investigation. my conclusion is that github changed the windows-latest image from being windows-2022 to windows-2025.

@youknowone how should we proceed? should we merge this PR? or should we pin the CI to use windows-2022? or even add another runner so we will check both 2022 and 2025 (if we do it, our patches will need to be slightly different)

youknowone approved these changes Sep 11, 2025
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wish we actually fix the problems, but any fix is better than no fix

youknowone merged commit 63de438 into RustPython:main Sep 11, 2025
12 checks passed
youknowone mentioned this pull request Dec 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL