| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Caution Review failedThe pull request is closed. WalkthroughA conditional guard preventing the ensurepip validation step from running on Windows is removed from the CI workflow, allowing the step to execute on all platforms. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem✨ Finishing touches 🧪 Generate unit tests (beta)
📜 Recent review details Configuration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro 📥 CommitsReviewing files that changed from the base of the PR and between 876368e and ccffecd. ⛔ Files ignored due to path filters (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
|
updated ensurepip but still not able to install pip |
Sorry, something went wrong.
Traceback (most recent call last):
File "<stdin>", line 6, in <module>
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 226, in run_module
return _run_module_code(code, init_globals, run_name, mod_spec)
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 96, in _run_module_code
with _TempModule(mod_name) as temp_module, _ModifiedArgv0(fname):
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 99, in _run_module_code
mod_name, mod_spec, pkg_name, script_name)
File "D:\a\RustPython\RustPython\pylib\Lib\runpy.py", line 88, in _run_code
exec(code, run_globals)
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\__main__.py", line 24, in <module>
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 69, in main
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main.py", line 65, in main
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\main_parser.py", line 79, in parse_command
File "D:\a\RustPython\RustPython\pylib/Lib\optparse.py", line 1371, in parse_args
values = self.get_default_values()
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 285, in get_default_values
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\cli\parser.py", line 283, in get_default_values
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 127, in load
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 258, in _load_config_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 353, in iter_config_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\configuration.py", line 73, in get_configuration_files
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_internal\utils\appdirs.py", line 47, in site_config_dirs
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\__init__.py", line 145, in site_config_dir
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 67, in site_config_dir
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 56, in site_data_dir
File "D:\a\RustPython\RustPython\pylib/Lib\functools.py", line 586, in wrapper
result = user_function(*args, **kwds)
File "C:\Users\RUNNER~1\AppData\Local\Temp\tmpsaacn1js\pip-25.2-py3-none-any.whl\pip\_vendor\platformdirs\windows.py", line 209, in get_win_folder_from_registry
FileNotFoundError: (2, 'The system cannot find the file specified. (os error 2)')
|
Sorry, something went wrong.
|
Okay, finally it is working. It is (probably) our first PIP running on windows. The changed wheel includes 2 patches: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
fix #5681
fix #2671
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.