Walkthrough

The build.rs file receives a formatting update. A multi-line else branch is collapsed to a single line, and the res.compile() call is reformatted with chained map_err. Functionality remains unchanged.

Changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Purely cosmetic formatting adjustments with no semantic changes
• No logic, control flow, or error handling modifications

Poem

🐰 A tidy build script hops along,
With formatted lines, neat and strong,
No logic bent, just cleaner views—
A rabbit's touch on builder's muse! ✨

Pre-merge checks and finishing touches

• 📝 Generate docstrings

• Create PR with unit tests
• Post copyable unit tests in a comment

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Reviewing files that changed from the base of the PR and between 2d46172 and 2f5515f.

• build.rs (1 hunks)

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.rs: Format Rust code with the default rustfmt style (run cargo fmt)
Run clippy and fix any warnings or lints introduced by your changes
Follow Rust best practices for error handling and memory management

Files:

• build.rs

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to Lib/test/**/*.py : When modifying CPython tests, add a '# TODO: RUSTPYTHON' comment documenting the reason

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Format Rust code with the default rustfmt style (run `cargo fmt`)

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Run clippy and fix any warnings or lints introduced by your changes

Learnt from: arihant2math
Repo: RustPython/RustPython PR: 5790
File: build.rs:2-2
Timestamp: 2025-06-28T16:31:03.991Z
Learning: In Cargo build scripts (build.rs), the environment variable CARGO_CFG_TARGET_OS is guaranteed to exist and is automatically set by Cargo during the build process, making unwrap() safe to use when accessing this variable.

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Run clippy and fix any warnings or lints introduced by your changes

Applied to files:

• build.rs

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Format Rust code with the default rustfmt style (run `cargo fmt`)

Applied to files:

• build.rs

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-09-11T05:06:59.971Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management

Applied to files:

• build.rs

• GitHub Check: auto_format

build.rs (1)

7-13: Run cargo fmt locally to correct the formatting in vm/build.rs.

The formatting at lines 7-13 in vm/build.rs does not match standard Rust formatting conventions:

• Line 7: The else block should not have the println! collapsed to the same line as the opening brace. Standard cargo fmt places each statement on a separate indented line:

  } else {
      println!("cargo:warning=logo.ico not found, skipping icon embedding");
      return;
  }

• Lines 10-13: The indentation pattern for the res.compile().map_err(...) chain and closure body appears non-standard.

Since the PR title references auto-formatting verification, these changes must conform to cargo fmt output. Run cargo fmt locally on vm/build.rs and commit the corrected formatting before merging.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt.
The changes have been committed with [skip ci] to avoid triggering another CI run.

Triggered by commit: 2f5515f3c22447b6741000e1942cc87edf656427
Last formatted: 2025-11-10T19:06:04Z

You may need to pull the latest changes before pushing again:

git pull origin main

@youknowone here it passes

@Piyush1045 this is because you're pushing from your main branch, which I don't recommend.