FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

move `derive-impl` -> `crates/derive-impl` by ShaharNaveh · Pull Request #6263 · RustPython/RustPython · GitHub

/ RustPython Public

move derive-impl -> crates/derive-impl - #6263

Merged
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:move-derive-impl
Nov 15, 2025
ConversationCommits (4)ChecksFiles changed
Merged

move derive-impl -> crates/derive-impl#6263
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:move-derive-impl

Conversation

ShaharNaveh commented Nov 14, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

ref: #6214

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration and adjusted an internal dependency reference to the new path to ensure consistent dependency resolution.
    • Removed an internal workspace member to streamline project organization and improve maintainability.

coderabbitai Bot commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Removed the derive-impl workspace member and updated the workspace dependency path for rustpython-derive-impl from derive-impl to crates/derive-impl in Cargo.toml.

Changes

Cohort / File(s) Summary
Workspace manifest
Cargo.toml		 Removed derive-impl from [workspace].members; changed workspace dependency rustpython-derive-impl path from derive-impl to crates/derive-impl in [workspace.dependencies]

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file manifest edits; check workspace member list and dependency path correctness.
  • Verify build and workspace resolution after path change.

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 In folders snug, a crate now sleeps,

Root no more — it softly creeps,
Paths adjusted, tidy and neat,
A hop, a nudge, the workspace complete.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: moving the derive-impl component to the crates/derive-impl directory path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a913127 and af36ec0.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

ShaharNaveh mentioned this pull request Nov 14, 2025
Open
16 tasks
youknowone merged commit 6479a20 into RustPython:main Nov 15, 2025
13 checks passed
coderabbitai Bot mentioned this pull request Nov 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL