Walkthrough

The __build_class__ function's public signature in crates/vm/src/stdlib/builtins.rs was updated to use a name parameter instead of qualified_name. Internal logic was refactored to derive the Python class name object directly from the new parameter, along with adjustments to metaclass resolution and argument construction.

Changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that all internal uses of the renamed parameter work correctly across metaclass resolution and class construction logic
• Check that callers of __build_class__ are updated to pass the correct parameter
• Confirm the __classcell__ check logic remains valid with the new parameter

Possibly related PRs

• __type_params__ in __build_class__ #5883: Also modifies __build_class__ implementation to add handling for .type_params / __type_params__ in the same file.

Poem

🐰 A class by any other name still builds true,
No more qualified names to confuse or construe,
With name so simple, the logic flows clean,
The metaclass knows just what we mean! ✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.