Walkthrough

Replaces the specialized PrintExpr instruction with an intrinsic-based flow: the compiler emits CallIntrinsic1(IntrinsicFunction1::Print) followed by Pop, the bytecode removes PrintExpr and adds IntrinsicFunction1::Print, and the VM dispatches printing via the intrinsic invoking sys.displayhook.

Changes

Sequence Diagram(s)

sequenceDiagram
  participant Codegen
  participant Bytecode
  participant VM
  participant Sys as sys.displayhook

  Note over Codegen,Bytecode: Compilation
  Codegen->>Bytecode: emit CallIntrinsic1(Print)
  Codegen->>Bytecode: emit Pop

  Note over Bytecode,VM: Execution
  VM->>VM: execute CallIntrinsic1(Print)
  VM->>Sys: invoke displayhook(arg)
  Sys-->>VM: return
  VM->>VM: execute Pop (cleanup)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Attention areas:
  • Both codegen locations emit the exact intrinsic + pop sequence.
  • VM intrinsic dispatcher correctly mirrors previous PrintExpr semantics (argument handling, exceptions).
  • Bytecode enum and stack-effect updates are consistent across consumers (disassembler, tests).

Possibly related PRs

• Remove ImportNameless bytecode #6325 — Similar removal of a dedicated instruction variant and replacement with intrinsic-based handling across codegen/bytecode/frame.
• typing TypeAlias #5945 — Same low-level refactor pattern: drop an Instruction variant and route through CallIntrinsic.
• Instruction::Resume #5944 — Converts specialized instructions into CallIntrinsic1 intrinsics and updates compiler + VM handling.

Suggested reviewers

• youknowone

Poem

🐰 I nibble bytes and hop between lanes,
I swapped the old print for intrinsic chains.
CallIntrinsic hums, then Pop wipes the track,
sys.displayhook answers — no rabbit needs slack! ✨

Pre-merge checks and finishing touches

• 📝 Generate docstrings

• Create PR with unit tests
• Post copyable unit tests in a comment

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Reviewing files that changed from the base of the PR and between 70c3bf4 and fcf6dec.

• crates/codegen/src/compile.rs (2 hunks)
• crates/compiler-core/src/bytecode.rs (1 hunks)
• crates/vm/src/frame.rs (1 hunks)

• crates/compiler-core/src/bytecode.rs
• crates/codegen/src/compile.rs
• crates/vm/src/frame.rs

• GitHub Check: Run snippets and cpython tests (windows-latest)
• GitHub Check: Run snippets and cpython tests on wasm-wasi
• GitHub Check: Run tests under miri
• GitHub Check: Check the WASM package and demo
• GitHub Check: Run snippets and cpython tests (macos-latest)
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Run rust tests (macos-latest)
• GitHub Check: Check Rust code with clippy
• GitHub Check: Ensure compilation on various targets
• GitHub Check: Run rust tests (windows-latest)
• GitHub Check: Run rust tests (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands and usage tips.