FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython · GitHub

  1. RustPython
  2. RustPython

Repository navigation

Unify property like objects - #635

Merged
cthulahoops merged 6 commits into
RustPython:masterfrom
BenLewis-Seequent:property_refactor
Mar 10, 2019
ConversationCommits (6)ChecksFiles changed
Merged

Unify property like objects#635
cthulahoops merged 6 commits into
RustPython:masterfrom
BenLewis-Seequent:property_refactor

Conversation

BenLewis-Seequent commented Mar 9, 2019

Copy link
Copy Markdown

Followup to #619, migrates property to the newer style and unify property like objects by:

  • making data descriptors an actual property, removing the need for an extra class.
  • making any property created from rust, which only has a getter(any use of vm.new_property) a readonly property. This means they can be overridden by the instance dict, hopefully leading to more consistent behavior.
  • changes member descriptors to be properties

codecov-io commented Mar 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #635 into master will increase coverage by 0.08%.
The diff coverage is 61.64%.

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   40.81%   40.89%   +0.08%     
==========================================
  Files          76       76              
  Lines       17345    17384      +39     
  Branches     4474     4479       +5     
==========================================
+ Hits         7079     7109      +30     
- Misses       8366     8384      +18     
+ Partials     1900     1891       -9
Impacted Files Coverage Δ
vm/src/obj/objfunction.rs 36.79% <100%> (-1.83%) ⬇️
vm/src/obj/objobject.rs 43.1% <42.85%> (+1.06%) ⬆️
vm/src/obj/objcode.rs 31.57% <50%> (-0.38%) ⬇️
vm/src/obj/objtype.rs 42.85% <50%> (+0.98%) ⬆️
vm/src/obj/objproperty.rs 58.49% <56.86%> (+17.31%) ⬆️
vm/src/pyobject.rs 59.58% <78.57%> (-1.35%) ⬇️
vm/src/vm.rs 54.46% <80%> (+0.01%) ⬆️
vm/src/function.rs 67.24% <84.61%> (+6.37%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010969f...7d01323. Read the comment docs.

BenLewis-Seequent mentioned this pull request Mar 9, 2019
Merged
windelbouwman reviewed Mar 9, 2019
View reviewed changes
Comment thread vm/src/vm.rs Outdated

windelbouwman commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

@cthulahoops could you have a look at this? It looks fine to me, but you are more into the descriptor things.

cthulahoops merged commit 9e5b76c into RustPython:master Mar 10, 2019
BenLewis-Seequent deleted the property_refactor branch March 29, 2019 06:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cthulahoops cthulahoops approved these changes
+1 more reviewer
windelbouwman windelbouwman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL