Actionable comments posted: 0

crates/stdlib/src/ssl.rs (1)

2594-2599: The expect() is safe but could use a more precise comment.

The is_empty() check at line 2591-2593 guarantees peer_certs is non-empty, making the expect() unreachable. However, the chain .map().last().expect() could be simplified for clarity.

Consider using last() directly on the slice:

-                peer_certs
-                    .iter()
-                    .map(|c| c.as_ref().to_vec())
-                    .last()
-                    .expect("is_empty checked above")
+                // peer_certs is guaranteed non-empty from check at line 2591
+                peer_certs.last().unwrap().as_ref().to_vec()

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Reviewing files that changed from the base of the PR and between db95946 and d514dc7.

• crates/stdlib/src/ssl.rs (7 hunks)

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style by running cargo fmt to format Rust code
Always run clippy to lint Rust code (cargo clippy) before completing tasks and fix any warnings or lints introduced by changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

• crates/stdlib/src/ssl.rs

Learnt from: CR
Repo: RustPython/RustPython PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-29T12:17:28.606Z
Learning: Applies to Lib/**/*.py : Minimize modifications to CPython standard library files in the `Lib/` directory; modifications should be minimal and only to work around RustPython limitations

• GitHub Check: Run snippets and cpython tests on wasm-wasi
• GitHub Check: Check the WASM package and demo
• GitHub Check: Run snippets and cpython tests (ubuntu-latest)
• GitHub Check: Check Rust code with clippy
• GitHub Check: Run snippets and cpython tests (macos-latest)
• GitHub Check: Ensure compilation on various targets
• GitHub Check: Run snippets and cpython tests (windows-latest)
• GitHub Check: Run rust tests (windows-latest)
• GitHub Check: Run rust tests (macos-latest)

crates/stdlib/src/ssl.rs (4)

1360-1431: Effective lock contention reduction.

The refactoring correctly moves argument parsing and I/O operations (file reading, CRL parsing) outside the critical section. The pattern of:

1. Parse all arguments first
2. Perform CRL detection and loading separately
3. Acquire write locks only for the final mutations

This is a sound approach that should significantly reduce lock hold time during certificate loading operations.

---

2717-2720: Good pattern to avoid nested lock contention.

Cloning the Arc before acquiring the inner mutex lock prevents holding the outer RwLock while waiting for the ParkingMutex. This is a correct defensive pattern against potential deadlocks.

---

3548-3562: LGTM - Lock scope minimized correctly.

The pattern of extracting DER bytes within a brief lock scope, then performing all parsing and dict conversion outside the lock is correct. The early returns for None cases are properly handled within the block expression.

---

3586-3620: Consistent lock minimization pattern.

Both cipher() and version() methods follow the same clean pattern: acquire lock briefly to extract the cipher suite, then release and process outside the lock. This is efficient since SupportedCipherSuite is a simple copyable type.