FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert function, method, builtin_*, frame, and generator to Any payload by OddCoincidence · Pull Request #642 · RustPython/RustPython · GitHub

  1. RustPython
  2. RustPython

Repository navigation

Convert function, method, builtin_*, frame, and generator to Any payload - #642

Merged
windelbouwman merged 5 commits into
masterfrom
joey/function-to-any
Mar 10, 2019
ConversationCommits (5)ChecksFiles changed
Merged

Convert function, method, builtin_*, frame, and generator to Any payload#642
windelbouwman merged 5 commits into
masterfrom
joey/function-to-any

Conversation

OddCoincidence commented Mar 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Getting so close now!

codecov-io commented Mar 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #642 into master will decrease coverage by 0.02%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   40.81%   40.78%   -0.03%     
==========================================
  Files          76       77       +1     
  Lines       17345    17383      +38     
  Branches     4474     4484      +10     
==========================================
+ Hits         7079     7090      +11     
- Misses       8366     8396      +30     
+ Partials     1900     1897       -3
Impacted Files Coverage Δ
vm/src/frame.rs 47.4% <10%> (+0.98%) ⬆️
vm/src/obj/objframe.rs 30.23% <100%> (-0.72%) ⬇️
vm/src/obj/objbuiltinfunc.rs 33.33% <33.33%> (ø)
vm/src/vm.rs 54.12% <66.66%> (-0.33%) ⬇️
vm/src/obj/objgenerator.rs 40.57% <7.14%> (-3.87%) ⬇️
vm/src/obj/objfunction.rs 32.94% <7.69%> (-5.68%) ⬇️
vm/src/pyobject.rs 61.52% <75%> (+0.59%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010969f...6eea407. Read the comment docs.

OddCoincidence changed the title Convert function / method to Any payload Convert function, method, builtin_*, frame, and generator to Any payload Mar 9, 2019
OddCoincidence mentioned this pull request Mar 9, 2019
Merged
windelbouwman reviewed Mar 10, 2019
View reviewed changes
Comment thread vm/src/vm.rs
trace!("invoke __call__ for: {:?}", payload);
self.call_method(&func_ref, "__call__", args)
}
if let Some(PyFunction {

windelbouwman Mar 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is a match statement no option here? I feel match is better than if statements with returns.

OddCoincidence Mar 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I can get rid of the explicit returns, but a match won't work here because each payload call is generic over the specific payload type.

(I do have some ideas on how to make this kind of thing cleaner and more efficient, but they're not fully baked yet.)

coolreader18 Mar 10, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we could use a macro, something like match_payload!, which would look like:

let match_res = match_payload!(pyobjref, {
    objint::PyInt(int) => do_thing(int.value),
    objfloat::PyFloat(objfloat::PyFloat { value }) => do_float_thing(value),
});

windelbouwman commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

I had some minor comment, but it looks good!

windelbouwman merged commit 79b4f62 into master Mar 10, 2019
OddCoincidence deleted the joey/function-to-any branch April 9, 2019 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

coolreader18 coolreader18 left review comments
+1 more reviewer
windelbouwman windelbouwman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL