Update `test_sys.py` from 3.13.11 by ShaharNaveh · Pull Request #6428 · RustPython/RustPython · GitHub

Summary by CodeRabbit

New Features
- Added a new sys module function to query Global Interpreter Lock (GIL) status. Users can now check the GIL implementation state programmatically.

✏️ Tip: You can customize this high-level summary in your review settings.

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

Lib/test/test_sys.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A new _is_gil_enabled() function was added to the sys module as a Python-exposed const function that returns false, indicating the GIL is not implemented in this environment.

Changes

Cohort / File(s)	Summary
GIL Status Function crates/vm/src/stdlib/sys.rs	Added new #[pyfunction] const fn _is_gil_enabled() -> bool that returns false to signal GIL is not available

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

youknowone

Poem

🐰 A GIL check hops into sys today,
Returns false in a gentle way,
No locks will bind these concurrent threads,
Freedom in code, the rabbit thread spreads! 🧵✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions updating test_sys.py from 3.13.11, but the actual changes add a new _is_gil_enabled() function to the sys module implementation, not test updates.	Update the title to accurately reflect the main change, such as 'Add _is_gil_enabled() function to sys module' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

It seems like

sysconfig.get_config_var('Py_GIL_DISABLED')

returns None (should return 1)

Currently fn exit in sys.rs is not checking the range of exit code. Checking it and return -1 for overflow will fix the failing test_exit

ShaharNaveh commented Dec 12, 2025

View reviewed changes

youknowone mentioned this pull request Dec 31, 2025

enhance error codec and exit code #6602

Merged

youknowone force-pushed the update-test-sys branch 2 times, most recently from 88134cc to d3bb267 Compare December 31, 2025 11:26

youknowone mentioned this pull request Jan 1, 2026

Fix stdio encoding #6617

Merged

fanninpm mentioned this pull request Jan 1, 2026

Update test/libregrtest to CPython 3.13.10 #6410

Merged

2 tasks

youknowone force-pushed the update-test-sys branch 3 times, most recently from f5fedb3 to bd538ac Compare January 1, 2026 07:54

youknowone and others added 4 commits January 1, 2026 17:36

mark RustPython as free-threaded

052dfe0

Py_GIL_DISABLED

5bb3c15

Update test_sys.py from 3.13.11

e0b826a

mark tests

aba3029

youknowone force-pushed the update-test-sys branch from bd538ac to aba3029 Compare January 1, 2026 08:37

youknowone merged commit 3e2ada0 into RustPython:main Jan 1, 2026
13 checks passed

coderabbitai Bot mentioned this pull request Jan 18, 2026

update test_sys from 3.14.2 #6781

Merged

Update `test_sys.py` from 3.13.11 by ShaharNaveh · Pull Request #6428 · RustPython/RustPython · GitHub

Uh oh!

Update test_sys.py from 3.13.11 - #6428

Update test_sys.py from 3.13.11#6428
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:update-test-sys

ShaharNaveh commented Dec 12, 2025 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Dec 12, 2025 •
edited
Loading

Uh oh!

Uh oh!

ShaharNaveh Dec 12, 2025

Uh oh!

youknowone commented Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                  # TODO: RUSTPYTHON, AtExit.__del__ is not invoked because module destruction is missing.
-                  @unittest.expectedFailure
+                  @unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: False is not true

Update `test_sys.py` from 3.13.11 by ShaharNaveh · Pull Request #6428 · RustPython/RustPython · GitHub

Uh oh!

Update test_sys.py from 3.13.11 - #6428

Update test_sys.py from 3.13.11#6428youknowone merged 4 commits intoRustPython:mainRustPython/RustPython:mainfrom ShaharNaveh:update-test-sysShaharNaveh/RustPython:update-test-sysCopy head branch name to clipboard

Conversation

ShaharNaveh commented Dec 12, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

ShaharNaveh Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone commented Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Update test_sys.py from 3.13.11#6428
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:update-test-sys

ShaharNaveh commented Dec 12, 2025 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Dec 12, 2025 •
edited
Loading