FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert memoryview and slice to Any payload by OddCoincidence · Pull Request #646 · RustPython/RustPython · GitHub

  1. RustPython
  2. RustPython

Repository navigation

Convert memoryview and slice to Any payload - #646

Merged
windelbouwman merged 9 commits into
masterfrom
joey/memoryview-slice
Mar 10, 2019
ConversationCommits (9)ChecksFiles changed
Merged

Convert memoryview and slice to Any payload#646
windelbouwman merged 9 commits into
masterfrom
joey/memoryview-slice

Conversation

OddCoincidence commented Mar 9, 2019

Copy link
Copy Markdown
Contributor

Based on #645 to avoid conflicts.

codecov-io commented Mar 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #646 into master will increase coverage by 0.27%.
The diff coverage is 31.7%.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   40.81%   41.08%   +0.27%     
==========================================
  Files          76       77       +1     
  Lines       17345    17525     +180     
  Branches     4474     4548      +74     
==========================================
+ Hits         7079     7201     +122     
- Misses       8366     8404      +38     
- Partials     1900     1920      +20
Impacted Files Coverage Δ
vm/src/obj/objmemory.rs 23.07% <0%> (-6.93%) ⬇️
vm/src/obj/objslice.rs 30.23% <10%> (+1.11%) ⬆️
vm/src/obj/objframe.rs 30.23% <100%> (-0.72%) ⬇️
vm/src/obj/objlist.rs 37.65% <100%> (+0.79%) ⬆️
vm/src/obj/objset.rs 48.72% <100%> (+0.09%) ⬆️
vm/src/obj/objbytes.rs 40.44% <100%> (+0.33%) ⬆️
vm/src/obj/objrange.rs 36.18% <18.75%> (+1.32%) ⬆️
vm/src/obj/objtuple.rs 26.59% <20%> (+0.37%) ⬆️
vm/src/frame.rs 46.52% <33.33%> (+0.1%) ⬆️
vm/src/obj/objstr.rs 34.85% <33.33%> (-0.38%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010969f...f6765cf. Read the comment docs.

windelbouwman reviewed Mar 10, 2019
View reviewed changes
Comment thread vm/src/obj/objrange.rs Outdated
};

_ => Err(vm.new_type_error("range indices must be integer or slice".to_string())),
return Ok(PyObject::new(

windelbouwman Mar 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Instead of if-with-a-return, do not use return, but the implement else. This gives less different return paths from the code.

OddCoincidence Mar 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, I went too fast here and got sloppy 😄

windelbouwman merged commit eb19eaa into master Mar 10, 2019
OddCoincidence deleted the joey/memoryview-slice branch April 9, 2019 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
windelbouwman windelbouwman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL