| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Important Review skippedBot user detected. To trigger a single review, invoke the @coderabbitai review command. You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Comment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
There was a problem hiding this comment.
Tests are good. Move it to append to builtin_exceptions.py
Sorry, something went wrong.
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
|
@copilot CPython doesnt pass extra_tests/snippets/builtin_exceptions.py. That means the test script has a bug |
Sorry, something went wrong.
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
| } else { | ||
| // VISIT(c, expr, e->v.Subscript.slice) | ||
| self.compile_expression(slice)?; | ||
| match slice { |
There was a problem hiding this comment.
I don't see this logic in CPython:
https://github.com/python/cpython/blob/627894459a84be3488a1789919679c997056a03c/Python/compile.c#L6669-L6678
Assuming that this works, I'd like to have a comment explaining why we are deviating from the CPython logic
Sorry, something went wrong.
| @@ -2121,12 +2130,150 @@ impl Compiler { | |||
|
|
|||
| fn compile_try_star_statement( | |||
There was a problem hiding this comment.
| fn compile_try_star_statement( | |
| fn compile_try_star_except( |
Sorry, something went wrong.
| let handler_block = self.new_block(); | ||
| let finally_block = self.new_block(); | ||
|
|
||
| if !finalbody.is_empty() { |
There was a problem hiding this comment.
I'd rather have it split like CPython does it
This makes it easier to maintain when looking for the diff between our impl and theirs
Sorry, something went wrong.
|
@copilot Address change request of @ShaharNaveh |
Sorry, something went wrong.
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
Addressed Shahar’s request by adopting a named constant for the duplicated stack copy in the except* codegen (commit 9b94189). |
Sorry, something went wrong.
|
hmm, probably copilot only reads change request by me |
Sorry, something went wrong.
Oof:/ |
Sorry, something went wrong.
|
not worth to do. I doubt copilot can finish this size one |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
- Investigate current failures and relevant code paths for except* and starred indexing
- Implement minimal runtime/support changes for except* handling
- Implement support for starred expressions in subscripts and related runtime behavior
- Add/adjust targeted tests validating new behaviors
- Run targeted checks/tests to verify changes
- Final review and cleanup
Original prompt💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.