FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update the signal + socketserver libraries + associated tests - v3.13.11 by terryluan12 · Pull Request #6631 · RustPython/RustPython · GitHub

/ RustPython Public

Update the signal + socketserver libraries + associated tests - v3.13.11 - #6631

Merged
youknowone merged 6 commits into
RustPython:mainfrom
terryluan12:update_signal_socket
Jan 3, 2026
ConversationCommits (6)ChecksFiles changed
Merged

Update the signal + socketserver libraries + associated tests - v3.13.11#6631
youknowone merged 6 commits into
RustPython:mainfrom
terryluan12:update_signal_socket

Conversation

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

coderabbitai Bot commented Jan 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Lib/socketserver.py is excluded by !Lib/**
  • Lib/test/test_signal.py is excluded by !Lib/**
  • Lib/test/test_socketserver.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

The subsocket.py file remains the same

youknowone commented Jan 3, 2026

Copy link
Copy Markdown
Member

macos failure is looking unrelated. i am investigating

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

macos failure is looking unrelated. i am investigating

Oh. Whoops. I did not see this. Sorry about that. Let me know if I should undo the changes

youknowone reviewed Jan 3, 2026
View reviewed changes
Comment thread Lib/test/test_ftplib.py Outdated
self.assertEqual(ftplib.parse257('257 "/foo/b""ar"'), '/foo/b"ar')
self.assertEqual(ftplib.parse257('257 "/foo/b""ar" created'), '/foo/b"ar')

@unittest.skipIf(sys.platform == "darwin", "TODO: RUSTPYTHON")

youknowone Jan 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#6635 will fix this regession

youknowone approved these changes Jan 3, 2026
View reviewed changes

youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

youknowone merged commit eea6cc4 into RustPython:main Jan 3, 2026
12 of 13 checks passed
terryluan12 mentioned this pull request Jan 3, 2026
Closed
terryluan12 changed the title Update the signal + socket libraries + associated tests - v3.13.11 Update the signal + socketserver libraries + associated tests - v3.13.11 Jan 5, 2026
terryluan12 deleted the update_signal_socket branch January 5, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL