FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

remove polluting tests by youknowone · Pull Request #6733 · RustPython/RustPython · GitHub

/ RustPython Public

remove polluting tests - #6733

Merged
youknowone merged 1 commit into
mainfrom
ci
Jan 14, 2026
ConversationCommits (1)ChecksFiles changed
Merged

remove polluting tests#6733
youknowone merged 1 commit into
mainfrom
ci

Conversation

youknowone commented Jan 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration to optimize test environment handling.

✏️ Tip: You can customize this high-level summary in your review settings.

coderabbitai Bot commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes two test entries from environment-polluting test lists in the CI workflow configuration. Specifically, multiprocessing fork server and spawn thread tests are removed from the Linux and macOS test pollution tracking environment variables.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
​.github/workflows/ci.yaml		 Removed test.test_multiprocessing_forkserver.test_threads from Linux environment-polluting tests and test.test_multiprocessing_spawn.test_threads from macOS environment-polluting tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two threads hop away,
From the pollution list they'd stay,
Linux and macOS now fly free,
The CI pipeline's spree! ✨

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3890f9 and 9c0a9dd.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

youknowone marked this pull request as ready for review January 14, 2026 23:36
youknowone merged commit b214362 into main Jan 14, 2026
13 of 17 checks passed
youknowone deleted the ci branch January 14, 2026 23:36
terryluan12 pushed a commit to terryluan12/RustPython that referenced this pull request Jan 15, 2026
remove polluting tests (RustPython#6733)
bf6340e

fanninpm commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Please also remove the corresponding lines in the test files themselves.

coderabbitai Bot mentioned this pull request Jan 20, 2026
Merged
coderabbitai Bot mentioned this pull request Jan 31, 2026
Merged
coderabbitai Bot mentioned this pull request Feb 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL