| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality⚠️ Potential issue | 🟠 Major
Avoid panic on non‑UTF‑8 Windows paths.
🔧 Proposed safer emissionto_str().unwrap() can panic on valid Windows paths containing non‑UTF‑8 sequences, breaking the build. Prefer a lossy conversion and consider warning when canonicalization fails so missing win_lib_path isn’t silent.
In `@crates/pylib/build.rs` around lines 14 - 31, The build script currently calls canonicalize(...).to_str().unwrap(), which can panic on non‑UTF‑8 Windows paths; change the emission to use a lossy conversion from the canonicalized Path (e.g., Path::to_string_lossy on the value returned by std::fs::canonicalize(&lib_path)) and print that into the cargo:rustc-env=win_lib_path value, and if std::fs::canonicalize(&lib_path) returns an Err emit a visible build warning via println!("cargo:warning=...") instead of silently skipping so missing win_lib_path is obvious; update the code paths referencing canonicalized_path and to_str().unwrap() accordingly.Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.