Fix Drop to prevent TLS data loss - #6825
Conversation
Sorry, something went wrong.
Remove pending_tls_output.clear() from Drop implementation. SSLSocket._real_close() in Python doesn't call shutdown() before closing - it just sets _sslobj = None. This means pending TLS data in the output buffer may not have been flushed to the socket yet. Clearing this buffer in Drop causes data loss, resulting in empty HTTP responses (test_socketserver failure on Windows). The explicit clearing is also unnecessary since all struct fields are automatically freed when the struct is dropped.
📝 Walkthrough
WalkthroughModified the PySSLSocket Drop implementation to remove explicit field clearing for pending_tls_output, write_buffered_len, and shutdown_state. Now only clears the connection explicitly while relying on automatic memory cleanup for other fields. Added explanatory comments about the rationale. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem🚥 Pre-merge checks | ✅ 3 ✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
Remove pending_tls_output.clear() from Drop implementation.
SSLSocket._real_close() in Python doesn't call shutdown() before closing - it just sets _sslobj = None. This means pending TLS data in the output buffer may not have been flushed to the socket yet. Clearing this buffer in Drop causes data loss, resulting in empty HTTP responses (test_socketserver failure on Windows).
The explicit clearing is also unnecessary since all struct fields are automatically freed when the struct is dropped.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.