FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure no warnings on various targets by ShaharNaveh · Pull Request #7245 · RustPython/RustPython · GitHub

/ RustPython Public

Ensure no warnings on various targets - #7245

Draft
ShaharNaveh wants to merge 12 commits into
RustPython:mainfrom
ShaharNaveh:disallow-warnings
ConversationCommits (12)ChecksFiles changed
Draft

Ensure no warnings on various targets#7245
ShaharNaveh wants to merge 12 commits into
RustPython:mainfrom
ShaharNaveh:disallow-warnings

Conversation

ShaharNaveh commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

ATM build on android yield an "unused import" warning. This PR aims to make sure warnings like this don't appear from time to time

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Code has been automatically formatted

The code in this PR has been formatted using:

  • ruff format
    Please pull the latest changes before pushing again:
git pull origin disallow-warnings

ShaharNaveh commented Feb 27, 2026
View reviewed changes
Comment thread crates/vm/src/stdlib/os.rs
#[pyarg(positional, default)]
#[pystruct_sequence(unnamed)]
pub st_mtime_int: libc::time_t,
#[cfg_attr(target_env = "musl", allow(deprecated))]

ShaharNaveh Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No matter what I do, the deprecation warning still shows. @youknowone I believe we have a bug related to #[cfg_attr(...)] with #[pystruct_sequence(...)] (and possibly related to when used with #[pyarg(...)])

ShaharNaveh mentioned this pull request Feb 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL