crates/vm/src/vm/mod.rs (1)

1163-1181: Consider extracting duplicate trace dispatch logic.

The trace handling in resume_gen_frame (lines 1163-1181) is nearly identical to with_frame_exc (lines 1094-1111). Per coding guidelines, consider extracting the common trace dispatch logic into a helper to reduce duplication.

♻️ Sketch of potential helper extraction

// Helper to handle trace dispatch around frame execution
fn dispatch_traced_frame<R>(
    &self,
    frame: &FrameRef,
    f: impl FnOnce() -> PyResult<R>,
) -> PyResult<R> {
    match self.trace_event(TraceEvent::Call, None) {
        Ok(trace_result) => {
            if let Some(local_trace) = trace_result {
                *frame.trace.lock() = local_trace;
            }
            let result = f();
            if result.is_ok()
                && self.use_tracing.get()
                && (!self.is_none(&frame.trace.lock())
                    || !self.is_none(&self.profile_func.borrow()))
            {
                let _ = self.trace_event(TraceEvent::Return, None);
            }
            result
        }
        Err(e) => Err(e),
    }
}

Then both with_frame_exc and resume_gen_frame can call this helper.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/vm/src/vm/mod.rs` around lines 1163 - 1181, Extract the duplicated
trace dispatch logic into a helper method (e.g., dispatch_traced_frame) and
replace the in-place logic in both resume_gen_frame and with_frame_exc with
calls to that helper; the helper should call self.trace_event(TraceEvent::Call,
None), apply any returned local trace into frame.trace.lock(), invoke the
provided closure to execute the frame body, and if the closure returns Ok and
tracing/profile is enabled (check self.use_tracing.get(), frame.trace.lock(),
and self.profile_func.borrow()), call self.trace_event(TraceEvent::Return, None)
before returning the closure result; ensure the helper accepts &self, frame:
&FrameRef, and a closure FnOnce() -> PyResult<T> so both resume_gen_frame and
with_frame_exc can pass their existing frame-execution closures.

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@crates/vm/src/vm/mod.rs`:
- Around line 1163-1181: Extract the duplicated trace dispatch logic into a
helper method (e.g., dispatch_traced_frame) and replace the in-place logic in
both resume_gen_frame and with_frame_exc with calls to that helper; the helper
should call self.trace_event(TraceEvent::Call, None), apply any returned local
trace into frame.trace.lock(), invoke the provided closure to execute the frame
body, and if the closure returns Ok and tracing/profile is enabled (check
self.use_tracing.get(), frame.trace.lock(), and self.profile_func.borrow()),
call self.trace_event(TraceEvent::Return, None) before returning the closure
result; ensure the helper accepts &self, frame: &FrameRef, and a closure
FnOnce() -> PyResult<T> so both resume_gen_frame and with_frame_exc can pass
their existing frame-execution closures.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Reviewing files that changed from the base of the PR and between 81acb9b and 754fc85.

• Lib/bdb.py is excluded by !Lib/**
• Lib/test/test_bdb.py is excluded by !Lib/**
• Lib/test/test_sys_settrace.py is excluded by !Lib/**

• crates/vm/src/protocol/callable.rs
• crates/vm/src/vm/mod.rs