FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

replace auto commit to format suggestion by youknowone · Pull Request #7375 · RustPython/RustPython · GitHub

replace auto commit to format suggestion - #7375

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:workflow
Mar 7, 2026
Merged

replace auto commit to format suggestion#7375
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:workflow

Conversation

youknowone commented Mar 7, 2026
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

fix #7311

Summary by CodeRabbit

  • Chores
    • Updated pull request formatting workflow. Automatic formatting and commit functionality has been removed. Formatting validation is now performed without auto-applying changes to PRs.

coderabbitai Bot commented Mar 7, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9fe86054-7616-4cfa-bedf-8228f5c01b8f

📥 Commits

Reviewing files that changed from the base of the PR and between fc1c278 and 8e48008.

📒 Files selected for processing (2)
  • .github/workflows/pr-auto-commit.yaml
  • .github/workflows/pr-format.yaml

📝 Walkthrough

Walkthrough

Removed the vulnerable pr-auto-commit.yaml workflow that auto-committed formatting changes to PRs, replacing it with a new pr-format.yaml workflow that performs format checks and posts non-invasive formatting suggestions via reviewdog instead.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/pr-auto-commit.yaml, .github/workflows/pr-format.yaml
Deleted vulnerable auto-commit workflow that directly interpolated branch names into shell commands. Added read-only format-check workflow using reviewdog to post inline formatting suggestions without committing to the PR branch.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh

Poem

🐰 A workflow once pushed with secrets so near,
Now safely suggests—without commit or fear!
Reviewdog whispers formatting advice,
No shell injections, no malicious splice,
The rabbit hops on, the pipeline is bright! ✨

✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

youknowone marked this pull request as ready for review March 7, 2026 05:52
youknowone enabled auto-merge (squash) March 7, 2026 05:52
youknowone disabled auto-merge March 7, 2026 05:53
youknowone merged commit ed5bffe into RustPython:main Mar 7, 2026
11 of 14 checks passed
youknowone deleted the workflow branch March 7, 2026 05:53
youknowone added a commit to youknowone/RustPython that referenced this pull request Mar 8, 2026
youknowone added a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Branch name injection in pr-auto-commit.yaml — actively exploited by hackerbot-claw

1 participant


Back | FazBrowse Home | New Git URL