Fix classmethod descr_get to match CPython behavior by ever0de · Pull Request #7420 · RustPython/RustPython · GitHub

Simplify classmethod.get to always create a PyBoundMethod binding the callable to the class, matching CPython's cm_descr_get which simply calls PyMethod_New(cm->cm_callable, type).

The previous implementation incorrectly tried to call get on the wrapped callable, which broke when a bound method was passed to classmethod() (e.g. classmethod(A().foo)).

CPython reference

https://github.com/python/cpython/blob/d9c26676b26ab09d8db7265dc22a733d3c358d4b/Objects/funcobject.c#L1458-L1471

Summary by CodeRabbit

Bug Fixes
- Simplified classmethod descriptor behavior so classmethods consistently resolve to bound methods and avoid unexpected errors from unnecessary attribute lookups.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 934f9e90-ae07-49d3-9ac3-e3922ec9a057

📥 Commits

Reviewing files that changed from the base of the PR and between 5280922 and aa16500.

⛔ Files ignored due to path filters (1)

Lib/test/test_decorators.py is excluded by !Lib/**

📒 Files selected for processing (1)

crates/vm/src/builtins/classmethod.rs

📝 Walkthrough

Walkthrough

PyClassMethod::descr_get was simplified: the prior lookup/invocation of the callable's __get__ attribute and its associated error handling were removed. The function now always returns a PyBoundMethod bound to the class and the callable (single code path).

Changes

Cohort / File(s)	Summary
Classmethod Descriptor Protocol crates/vm/src/builtins/classmethod.rs	Removed __get__ attribute lookup and conditional invocation in PyClassMethod::descr_get. Always returns PyBoundMethod(cls, callable); error handling and alternate control paths for descriptor delegation removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Fix potential deadlocks #6509: Modifies the same PyClassMethod::descr_get function; related to changes in classmethod descriptor handling.

Poem

🐰 I hopped through code with nimble feet,
Removed a branch, made binding neat,
No more "get" to slow the run —
A simpler hop, the job is done! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: simplifying classmethod.descr_get to match CPython behavior by removing descriptor protocol invocation on the callable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] lib: cpython/Lib/locale.py
[ ] test: cpython/Lib/test/test_locale.py
[x] test: cpython/Lib/test/test__locale.py

dependencies:

locale (native: _locale, builtins, encodings.aliases, sys)
- _collections_abc, encodings, functools, os, re, warnings

dependent tests: (96 tests)

locale: test__locale test_builtin test_c_locale_coercion test_calendar test_decimal test_float test_format test_inspect test_io test_locale test_os test_re test_regrtest test_strftime test_sys test_types test_utf8_mode
- calendar: test_imaplib
  - http.cookiejar: test_http_cookiejar test_urllib2
  - mailbox: test_genericalias test_mailbox
  - ssl: test_asyncio test_ftplib test_httplib test_httpservers test_logging test_poplib test_ssl test_urllib test_urllib2_localnet test_venv test_xmlrpc
- gettext: test_gettext test_tools
  - argparse: test_argparse
  - getopt: test_getopt
  - optparse: test_optparse
- site: test_site
- subprocess: test_android test_asyncio test_atexit test_audit test_bz2 test_cmd_line test_cmd_line_script test_ctypes test_dtrace test_faulthandler test_file_eintr test_gc test_gzip test_json test_launcher test_msvcrt test_ntpath test_osx_env test_platform test_plistlib test_poll test_py_compile test_quopri test_repl test_runpy test_script_helper test_select test_shutil test_signal test_sqlite3 test_subprocess test_support test_sysconfig test_tempfile test_threading test_traceback test_unittest test_wait3 test_webbrowser test_zipfile
  - ctypes.util: test_ctypes
  - ensurepip: test_ensurepip
  - multiprocessing.util: test_asyncio test_compileall test_concurrent_futures
  - platform: test__osx_support test_asyncio test_baseexception test_cmath test_fcntl test_math test_mimetypes test_posix test_socket test_time test_winreg test_wsgiref

[x] lib: cpython/Lib/modulefinder.py
[x] test: cpython/Lib/test/test_modulefinder.py (TODO: 2)

dependencies:

modulefinder

dependent tests: (2 tests)

modulefinder: test_importlib test_modulefinder

[ ] lib: cpython/Lib/pkgutil.py
[ ] test: cpython/Lib/test/test_pkgutil.py (TODO: 1)

dependencies:

pkgutil (native: importlib.machinery, importlib.util, marshal, os.path, sys)
- collections (native: _collections, _weakref, itertools, sys)
- functools, importlib, inspect, os, re, zipimport

dependent tests: (7 tests)

pkgutil: test_pkgutil test_pydoc test_runpy
- pydoc: test_enum
  - xmlrpc.server: test_docxmlrpc test_xmlrpc
- runpy:
  - trace: test_trace

[x] lib: cpython/Lib/poplib.py
[x] test: cpython/Lib/test/test_poplib.py

dependencies:

poplib

dependent tests: (1 tests)

poplib: test_poplib

[ ] lib: cpython/Lib/smtplib.py
[x] test: cpython/Lib/test/test_smtplib.py
[x] test: cpython/Lib/test/test_smtpnet.py

dependencies:

smtplib (native: email.base64mime, email.generator, email.message, email.utils, sys)
- base64, copy, datetime, hmac, io, re, socket, ssl

dependent tests: (5 tests)

smtplib: test_smtplib test_smtpnet
- logging.handlers: test_concurrent_futures test_logging test_pkgutil

[ ] lib: cpython/Lib/asyncio
[ ] test: cpython/Lib/test/test_asyncio (TODO: 38)

dependencies:

asyncio (native: _asyncio, _overlapped, _pyrepl.console, _pyrepl.main, _pyrepl.simple_interact, _remote_debugging, _winapi, asyncio.tools, base_events, collections.abc, concurrent.futures, coroutines, errno, events, exceptions, futures, graph, itertools, locks, log, math, msvcrt, protocols, queues, readline, runners, streams, sys, taskgroups, tasks, threads, time, timeouts, transports, unix_events, windows_events)
- logging (native: atexit, collections.abc, email.message, email.utils, errno, http.client, logging.handlers, multiprocessing.queues, select, sys, time, urllib.parse, win32evtlog, win32evtlogutil)
- site (native: _io, _pyrepl.main, _pyrepl.pager, _pyrepl.readline, _pyrepl.unix_console, _pyrepl.windows_console, atexit, builtins, errno, readline, sitecustomize, sys, usercustomize)
- tokenize (native: _tokenize, builtins, itertools, sys)
- collections
- _colorize, argparse, ast, contextlib, contextvars, dataclasses, enum, functools, heapq, inspect, io, linecache, os, reprlib, rlcompleter, selectors, signal, socket, ssl, stat, struct, subprocess, tempfile, threading, traceback, types, warnings, weakref

dependent tests: (7 tests)

asyncio: test_asyncio test_contextlib_async test_inspect test_logging test_os test_sys_settrace test_unittest

[x] test: cpython/Lib/test/test_builtin.py (TODO: 25)

dependencies:

dependent tests: (no tests depend on builtin)

[ ] lib: cpython/Lib/collections
[x] lib: cpython/Lib/_collections_abc.py
[x] test: cpython/Lib/test/test_collections.py (TODO: 3)
[x] test: cpython/Lib/test/test_deque.py (TODO: 3)
[x] test: cpython/Lib/test/test_defaultdict.py (TODO: 1)
[x] test: cpython/Lib/test/test_ordered_dict.py (TODO: 8)

dependencies:

collections

dependent tests: (302 tests)

collections: test_annotationlib test_array test_asyncio test_bisect test_builtin test_c_locale_coercion test_call test_collections test_configparser test_contains test_copy test_csv test_ctypes test_defaultdict test_deque test_descr test_dict test_dictviews test_enum test_exception_group test_file test_fileinput test_fileio test_frame test_funcattrs test_functools test_genericalias test_hash test_httpservers test_inspect test_io test_ipaddress test_iter test_iterlen test_json test_logging test_math test_monitoring test_ordered_dict test_pathlib test_patma test_pickle test_plistlib test_pprint test_pydoc test_random test_reprlib test_richcmp test_set test_shelve test_sqlite3 test_statistics test_string test_struct test_sys test_traceback test_tuple test_types test_typing test_unittest test_urllib test_userdict test_userlist test_userstring test_weakref test_weakset test_with
- ast: test_ast test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_site test_ssl test_type_comments test_ucn test_unparse
  - annotationlib: test_type_annotations test_type_params
  - dbm.dumb: test_dbm_dumb
  - inspect: test_abc test_argparse test_asyncgen test_buffer test_code test_coroutines test_decimal test_generators test_grammar test_ntpath test_operator test_posixpath test_signal test_yield_from test_zipimport test_zoneinfo
  - pyclbr: test_pyclbr
  - traceback: test_asyncio test_code_module test_contextlib test_contextlib_async test_dictcomps test_exceptions test_http_cookiejar test_importlib test_listcomps test_pyexpat test_setcomps test_socket test_subprocess test_threadedtempfile test_threading test_unittest
- asyncio: test_asyncio test_os test_sys_settrace
- concurrent.futures._base: test_concurrent_futures
- dbm.sqlite3: test_dbm_sqlite3
- difflib: test_difflib
- dis: test__opcode test_compiler_assemble test_dtrace test_opcache test_peepholer test_positional_only_arg
  - bdb: test_bdb
  - modulefinder: test_importlib test_modulefinder
  - trace: test_trace
- email.feedparser: test_email
- http.client: test_docxmlrpc test_hashlib test_unicodedata test_urllib2 test_wsgiref test_xmlrpc
  - urllib.request: test_sax test_urllib2_localnet test_urllib2net test_urllibnet
- importlib.metadata: test_importlib
- inspect:
  - cmd: test_cmd
  - dataclasses: test__colorize test_ctypes test_regrtest
  - pkgutil: test_pkgutil test_runpy
  - rlcompleter: test_rlcompleter
- logging: test_support
  - hashlib: test_hmac test_smtplib test_tarfile
  - multiprocessing.util: test_compileall test_concurrent_futures
  - venv: test_venv
- multiprocessing: test_fcntl test_memoryview test_multiprocessing_main_handling test_re
- platform: test__locale test__osx_support test_android test_baseexception test_cmath test_ctypes test_mimetypes test_platform test_posix test_shutil test_sysconfig test_time test_winreg
- pprint: test_htmlparser test_sys_setprofile
  - pickle: test_bool test_bytes test_bz2 test_codecs test_concurrent_futures test_ctypes test_email test_enumerate test_fractions test_http_cookies test_itertools test_list test_lzma test_memoryio test_minidom test_picklebuffer test_pickletools test_range test_slice test_str test_type_aliases test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo
- queue: test_dummy_thread test_sched
- selectors: test_selectors
  - socket: test_epoll test_exception_hierarchy test_ftplib test_httplib test_imaplib test_kqueue test_largefile test_mailbox test_mmap test_poplib test_pty test_smtpnet test_socketserver test_stat test_timeout test_urllib_response
  - subprocess: test_atexit test_audit test_cmd_line test_cmd_line_script test_ctypes test_faulthandler test_file_eintr test_gc test_gzip test_json test_launcher test_msvcrt test_osx_env test_poll test_py_compile test_quopri test_repl test_script_helper test_select test_tempfile test_unittest test_utf8_mode test_wait3 test_webbrowser test_zipfile
- shlex: test_shlex
- shutil: test_filecmp test_glob test_importlib test_string_literals test_unicode_file
  - ctypes.util: test_ctypes
  - ensurepip: test_ensurepip
  - pathlib: test_importlib test_pathlib test_tomllib test_tools test_winapi test_zipapp test_zstd
  - tempfile: test_doctest test_importlib test_linecache test_pkg test_tabnanny test_termios test_winconsoleio test_zipfile64
  - zipfile: test_zipfile
- statistics:
  - random: test_complex test_context test_devpoll test_float test_heapq test_int test_long test_numeric_tower test_pow test_queue test_sort test_strtod test_thread test_tokenize
- string: test_email test_fnmatch test_secrets test_string
- threading: test_concurrent_futures test_ctypes test_fork1 test_importlib test_robotparser test_super test_syslog test_threading_local
  - dummy_threading: test_dummy_threading
  - sysconfig: test_tools
- traceback:
  - timeit: test_timeit
- urllib.parse: test_urlparse
- wave: test_wave

[ ] lib: cpython/Lib/concurrent
[ ] test: cpython/Lib/test/test_concurrent_futures (TODO: 18)
[ ] test: cpython/Lib/test/test_interpreters
[ ] test: cpython/Lib/test/test__interpreters.py
[ ] test: cpython/Lib/test/test__interpchannels.py
[ ] test: cpython/Lib/test/test_crossinterp.py

dependencies:

concurrent (native: _crossinterp, _interpqueues, _interpreters, _queues, concurrent.futures, concurrent.futures._base, interpreter, itertools, multiprocessing.connection, multiprocessing.queues, multiprocessing.synchronize, process, sys, thread, time)
- multiprocessing (native: _multiprocessing, _posixshmem, _posixsubprocess, _winapi, array, atexit, collections.abc, connection, context, dummy, errno, forkserver, heap, itertools, managers, mmap, msvcrt, multiprocessing.connection, pool, popen_fork, popen_forkserver, popen_spawn_posix, popen_spawn_win32, queues, resource_sharer, resource_tracker, sharedctypes, spawn, synchronize, sys, time, util, xmlrpc.client)
- pickle (native: _pickle, itertools, sys)
- collections, logging
- functools, os, queue, threading, traceback, types, weakref

dependent tests: (16 tests)

concurrent: test_asyncio test_compileall test_concurrent_futures test_context test_genericalias test_inspect test_struct test_sys test_types test_wmi
- asyncio: test_asyncio test_contextlib_async test_logging test_os test_sys_settrace test_unittest

[x] lib: cpython/Lib/dataclasses.py
[x] test: cpython/Lib/test/test_dataclasses (TODO: 10)

dependencies:

dataclasses

dependent tests: (90 tests)

dataclasses: test__colorize test_copy test_ctypes test_enum test_genericalias test_patma test_pprint test_pydoc test_regrtest test_typing test_zoneinfo
- pprint: test_htmlparser test_ssl test_sys_setprofile test_unittest
  - pickle: test_annotationlib test_array test_ast test_asyncio test_bool test_builtin test_bytes test_bz2 test_codecs test_collections test_concurrent_futures test_configparser test_coroutines test_csv test_ctypes test_decimal test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enumerate test_exceptions test_fractions test_functools test_generators test_http_cookies test_importlib test_inspect test_io test_ipaddress test_iter test_itertools test_list test_logging test_lzma test_memoryio test_memoryview test_minidom test_opcache test_operator test_ordered_dict test_os test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_plistlib test_positional_only_arg test_posix test_random test_range test_re test_set test_shelve test_slice test_socket test_statistics test_str test_string test_time test_trace test_tuple test_type_aliases test_type_params test_types test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo

[ ] test: cpython/Lib/test/test_decorators.py

dependencies:

dependent tests: (no tests depend on decorators)

[ ] test: cpython/Lib/test/test_descr.py (TODO: 47)
[ ] test: cpython/Lib/test/test_descrtut.py (TODO: 3)

dependencies:

dependent tests: (no tests depend on descr)

[x] lib: cpython/Lib/doctest.py
[ ] test: cpython/Lib/test/test_doctest (TODO: 9)

dependencies:

doctest

dependent tests: (33 tests)

doctest: test_builtin test_cmd test_code test_collections test_ctypes test_decimal test_deque test_descrtut test_difflib test_doctest test_doctest2 test_enum test_extcall test_generators test_getopt test_heapq test_http_cookies test_itertools test_listcomps test_math test_metaclass test_pep646_syntax test_pickle test_pickletools test_setcomps test_statistics test_syntax test_threading_local test_typing test_unpack test_unpack_ex test_weakref test_zipimport

[x] test: cpython/Lib/test/test_fork1.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on fork1)

[x] test: cpython/Lib/test/test_format.py (TODO: 7)

dependencies:

dependent tests: (no tests depend on format)

[x] test: cpython/Lib/test/test_frame.py (TODO: 14)

dependencies:

dependent tests: (no tests depend on frame)

[x] lib: cpython/Lib/ftplib.py
[x] test: cpython/Lib/test/test_ftplib.py (TODO: 4)

dependencies:

ftplib

dependent tests: (34 tests)

ftplib: test_ftplib test_urllib2
- urllib.request: test_http_cookiejar test_pathlib test_pydoc test_sax test_site test_ssl test_urllib test_urllib2_localnet test_urllib2net test_urllibnet
  - pathlib: test_ast test_dbm_sqlite3 test_ensurepip test_httpservers test_importlib test_launcher test_logging test_pathlib test_pkgutil test_runpy test_tarfile test_tempfile test_tomllib test_tools test_traceback test_unparse test_venv test_winapi test_zipapp test_zipfile test_zoneinfo test_zstd

[x] test: cpython/Lib/test/test_gc.py

dependencies:

dependent tests: (168 tests)

gc: test_array test_asyncio test_baseexception test_builtin test_call test_class test_context test_csv test_ctypes test_deque test_descr test_dict test_enum test_enumerate test_functools test_gc test_generators test_gzip test_inspect test_itertools test_logging test_memoryio test_memoryview test_ordered_dict test_peepholer test_pickle test_picklebuffer test_raise test_set test_socket test_ssl test_struct test_subprocess test_sys test_sys_setprofile test_sys_settrace test_tempfile test_tuple test_types test_typing test_unittest test_weakref test_weakset test_winreg test_zoneinfo test_zstd
- timeit: test_timeit
- trace: test_trace
- weakref: test_ast test_asyncio test_code test_concurrent_futures test_contextlib test_copy test_exceptions test_file test_fileio test_frame test_genericalias test_importlib test_io test_ipaddress test_mmap test_queue test_re test_scope test_slice test_sqlite3 test_thread test_threading test_threading_local test_type_params test_unittest test_uuid test_xml_etree
  - asyncio: test_asyncio test_contextlib_async test_os test_unittest
  - bdb: test_bdb
  - concurrent.futures.process: test_compileall test_concurrent_futures
  - copy: test_bytes test_codecs test_collections test_copyreg test_coroutines test_decimal test_defaultdict test_dictviews test_email test_fractions test_http_cookies test_minidom test_opcache test_optparse test_platform test_plistlib test_posix test_site test_statistics test_sysconfig test_tomllib test_urllib2 test_xml_dom_minicompat test_zlib
  - gzip: test_fileinput test_tarfile test_xmlrpc
  - inspect: test_abc test_argparse test_asyncgen test_buffer test_grammar test_monitoring test_ntpath test_operator test_patma test_posixpath test_pydoc test_signal test_sqlite3 test_traceback test_type_annotations test_yield_from test_zipimport
  - logging: test_hashlib test_pkgutil test_support test_urllib2net
  - multiprocessing: test_concurrent_futures test_fcntl test_multiprocessing_main_handling
  - symtable: test_symtable
  - tempfile: test_bz2 test_cmd_line test_compile test_ctypes test_dis test_doctest test_ensurepip test_faulthandler test_filecmp test_httpservers test_importlib test_launcher test_linecache test_mailbox test_modulefinder test_pathlib test_pkg test_py_compile test_regrtest test_runpy test_selectors test_shutil test_string_literals test_tabnanny test_termios test_threadedtempfile test_urllib test_urllib_response test_venv test_winconsoleio test_zipapp test_zipfile test_zipfile64
  - xml.sax.expatreader: test_sax

[ ] test: cpython/Lib/test/test_generators.py (TODO: 12)
[ ] test: cpython/Lib/test/test_genexps.py
[x] test: cpython/Lib/test/test_generator_stop.py (TODO: 1)
[ ] test: cpython/Lib/test/test_yield_from.py (TODO: 6)

dependencies:

dependent tests: (no tests depend on generator)

[x] lib: cpython/Lib/importlib
[ ] test: cpython/Lib/test/test_importlib (TODO: 15)

dependencies:

importlib

dependent tests: (112 tests)

importlib: test_bdb test_cmd_line_script test_codecs test_compileall test_ctypes test_doctest test_frozen test_hashlib test_importlib test_inspect test_linecache test_modulefinder test_multiprocessing_main_handling test_pkgutil test_py_compile test_pyclbr test_pydoc test_reprlib test_runpy test_sundry test_support test_tomllib test_unittest test_zipfile test_zipimport test_zoneinfo
- ctypes.util: test_ctypes
- ensurepip: test_ensurepip test_venv
- inspect: test_abc test_argparse test_asyncgen test_buffer test_builtin test_code test_collections test_coroutines test_decimal test_enum test_functools test_generators test_grammar test_monitoring test_ntpath test_operator test_patma test_posixpath test_signal test_sqlite3 test_traceback test_type_annotations test_types test_typing test_unittest test_yield_from
  - ast: test_ast test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_site test_ssl test_type_comments test_ucn test_unparse
  - asyncio: test_asyncio test_contextlib_async test_logging test_os test_sys_settrace test_unittest
  - cmd: test_cmd
  - dataclasses: test__colorize test_copy test_ctypes test_genericalias test_pprint test_regrtest
  - rlcompleter: test_rlcompleter
  - trace: test_trace
  - xmlrpc.server: test_docxmlrpc test_xmlrpc
- py_compile: test_importlib
  - zipfile: test_shutil test_zipapp test_zipfile test_zipfile64
- sysconfig: test_c_locale_coercion test_dtrace test_gc test_launcher test_osx_env test_posix test_pyexpat test_subprocess test_sys test_sysconfig test_time test_tools test_urllib2net
- zipfile:
  - shutil: test_bz2 test_filecmp test_glob test_httpservers test_largefile test_sax test_string_literals test_tarfile test_tempfile test_unicode_file
- zipimport: test_importlib

[ ] lib: cpython/Lib/multiprocessing
[ ] test: cpython/Lib/test/test_multiprocessing_fork (TODO: 35)
[ ] test: cpython/Lib/test/test_multiprocessing_forkserver (TODO: 10)
[ ] test: cpython/Lib/test/test_multiprocessing_spawn (TODO: 13)
[x] test: cpython/Lib/test/test_multiprocessing_main_handling.py
[ ] test: cpython/Lib/test/_test_multiprocessing.py (TODO: 15)

dependencies:

multiprocessing

dependent tests: (11 tests)

multiprocessing: test_asyncio test_compileall test_concurrent_futures test_fcntl test_genericalias test_logging test_memoryview test_multiprocessing_main_handling test_re test_socket
- concurrent.futures.process: test_concurrent_futures

[x] lib: cpython/Lib/os.py
[ ] test: cpython/Lib/test/test_os.py (TODO: 2)
[x] test: cpython/Lib/test/test_popen.py

dependencies:

os

dependent tests: (171 tests)

os: test___all__ test__osx_support test_argparse test_ast test_asyncio test_atexit test_base64 test_baseexception test_bdb test_bool test_buffer test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_cmd_line test_cmd_line_script test_codecs test_compile test_compileall test_concurrent_futures test_configparser test_contextlib test_ctypes test_dbm test_dbm_dumb test_dbm_sqlite3 test_decimal test_devpoll test_doctest test_dtrace test_eintr test_email test_ensurepip test_enum test_epoll test_exception_hierarchy test_exceptions test_faulthandler test_fcntl test_file test_file_eintr test_filecmp test_fileinput test_fileio test_float test_fnmatch test_fork1 test_fractions test_fstring test_ftplib test_future_stmt test_genericalias test_genericpath test_getpass test_gettext test_glob test_graphlib test_gzip test_hash test_hashlib test_http_cookiejar test_httplib test_httpservers test_imaplib test_importlib test_inspect test_io test_ioctl test_json test_kqueue test_largefile test_launcher test_linecache test_locale test_logging test_lzma test_mailbox test_marshal test_math test_mimetypes test_mmap test_modulefinder test_msvcrt test_multiprocessing_fork test_multiprocessing_forkserver test_multiprocessing_main_handling test_multiprocessing_spawn test_netrc test_ntpath test_openpty test_optparse test_os test_pathlib test_pkg test_pkgutil test_platform test_plistlib test_poll test_popen test_poplib test_posix test_posixpath test_pty test_py_compile test_pydoc test_pyexpat test_random test_regrtest test_repl test_reprlib test_robotparser test_runpy test_sax test_script_helper test_selectors test_shelve test_shutil test_signal test_site test_smtpnet test_socket test_socketserver test_sqlite3 test_ssl test_stat test_string_literals test_structseq test_subprocess test_support test_sys test_sysconfig test_tabnanny test_tarfile test_tempfile test_termios test_thread test_threading test_threadsignals test_time test_tokenize test_tools test_trace test_tty test_typing test_unicode_file test_unicode_file_functions test_unittest test_univnewlines test_urllib test_urllib2 test_urllib2_localnet test_urllib2net test_urllibnet test_uuid test_venv test_wait3 test_wait4 test_wave test_webbrowser test_winapi test_winconsoleio test_winreg test_winsound test_wsgiref test_xml_etree test_zipfile test_zipimport test_zoneinfo test_zstd

[x] lib: cpython/Lib/pickle.py
[ ] lib: cpython/Lib/_compat_pickle.py
[ ] test: cpython/Lib/test/test_pickle.py (TODO: 21)
[ ] test: cpython/Lib/test/test_picklebuffer.py (TODO: 12)
[ ] test: cpython/Lib/test/test_pickletools.py (TODO: 8)

dependencies:

pickle

dependent tests: (97 tests)

pickle: test_annotationlib test_array test_ast test_asyncio test_bool test_builtin test_bytes test_bz2 test_codecs test_collections test_concurrent_futures test_configparser test_coroutines test_csv test_ctypes test_decimal test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enum test_enumerate test_exceptions test_fractions test_functools test_generators test_genericalias test_http_cookies test_importlib test_inspect test_io test_ipaddress test_iter test_itertools test_list test_logging test_lzma test_memoryio test_memoryview test_minidom test_opcache test_operator test_ordered_dict test_os test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_plistlib test_positional_only_arg test_posix test_random test_range test_re test_set test_shelve test_slice test_socket test_statistics test_str test_string test_time test_trace test_tuple test_type_aliases test_type_params test_types test_typing test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo
- logging: test_asyncio test_concurrent_futures test_hashlib test_pkgutil test_support test_urllib2net
  - asyncio.futures: test_asyncio
  - concurrent.futures._base: test_concurrent_futures
  - hashlib: test_hmac test_smtplib test_tarfile test_unicodedata test_urllib2_localnet
  - http.cookiejar: test_http_cookiejar test_urllib2
  - multiprocessing.util: test_asyncio test_compileall test_concurrent_futures
  - venv: test_venv

[ ] test: cpython/Lib/test/test_raise.py

dependencies:

dependent tests: (no tests depend on raise)

[x] lib: cpython/Lib/runpy.py
[x] test: cpython/Lib/test/test_runpy.py (TODO: 2)

dependencies:

runpy

dependent tests: (2 tests)

runpy: test_runpy
- trace: test_trace

[x] lib: cpython/Lib/symtable.py
[ ] test: cpython/Lib/test/test_symtable.py (TODO: 17)

dependencies:

symtable

dependent tests: (2 tests)

symtable: test_inspect test_symtable

[x] lib: cpython/Lib/tabnanny.py
[ ] test: cpython/Lib/test/test_tabnanny.py (TODO: 5)

dependencies:

tabnanny

dependent tests: (1 tests)

tabnanny: test_tabnanny

[x] lib: cpython/Lib/threading.py
[x] lib: cpython/Lib/_threading_local.py
[ ] test: cpython/Lib/test/test_threading.py (TODO: 18)
[ ] test: cpython/Lib/test/test_threadedtempfile.py
[ ] test: cpython/Lib/test/test_threading_local.py (TODO: 3)

dependencies:

threading

dependent tests: (150 tests)

threading: test_android test_asyncio test_bz2 test_code test_concurrent_futures test_contextlib test_ctypes test_decimal test_docxmlrpc test_email test_enum test_fork1 test_frame test_ftplib test_functools test_gc test_hashlib test_httplib test_httpservers test_imaplib test_importlib test_inspect test_io test_itertools test_largefile test_linecache test_logging test_memoryview test_opcache test_pathlib test_poll test_poplib test_queue test_robotparser test_sched test_signal test_smtplib test_socket test_socketserver test_sqlite3 test_ssl test_subprocess test_super test_sys test_syslog test_termios test_threadedtempfile test_threading test_threading_local test_time test_urllib2_localnet test_weakref test_winreg test_wsgiref test_xmlrpc test_zstd
- asyncio: test_asyncio test_contextlib_async test_os test_sys_settrace test_unittest
- bdb: test_bdb
- concurrent.futures._base: test_concurrent_futures
- concurrent.futures.process: test_compileall test_concurrent_futures
- concurrent.futures.thread: test_genericalias
- dummy_threading: test_dummy_threading
- http.cookiejar: test_http_cookiejar test_urllib2
  - urllib.request: test_pathlib test_pydoc test_sax test_site test_urllib test_urllib2net test_urllibnet
- importlib.util: test_ctypes test_doctest test_importlib test_pkgutil test_py_compile test_reprlib test_runpy test_zipfile test_zipimport
  - py_compile: test_argparse test_cmd_line_script test_importlib test_modulefinder test_multiprocessing_main_handling
  - pyclbr: test_pyclbr
  - sysconfig: test_c_locale_coercion test_dtrace test_launcher test_osx_env test_posix test_pyexpat test_regrtest test_support test_sysconfig test_tools test_venv
  - zipfile: test_shutil test_zipapp test_zipfile test_zipfile64
- logging: test_unittest
  - hashlib: test_hmac test_tarfile test_unicodedata
- multiprocessing: test_fcntl test_re
- queue: test_dummy_thread
- subprocess: test_atexit test_audit test_cmd_line test_ctypes test_faulthandler test_file_eintr test_gzip test_json test_msvcrt test_ntpath test_platform test_plistlib test_quopri test_repl test_script_helper test_select test_tempfile test_traceback test_unittest test_utf8_mode test_wait3 test_webbrowser
  - ctypes.util: test_ctypes
  - ensurepip: test_ensurepip
  - platform: test__locale test__osx_support test_baseexception test_builtin test_cmath test_math test_mimetypes
- sysconfig:
  - trace: test_trace
- zipfile:
  - shutil: test_filecmp test_glob test_string_literals test_unicode_file test_zoneinfo

[ ] lib: cpython/Lib/tokenize.py
[ ] test: cpython/Lib/test/test_tokenize.py (TODO: 2)

dependencies:

tokenize

dependent tests: (135 tests)

tokenize: test_inspect test_linecache test_tabnanny test_tokenize test_unparse
- importlib._bootstrap_external: test_importlib test_unittest
  - modulefinder: test_importlib test_modulefinder
  - py_compile: test_argparse test_cmd_line_script test_compileall test_importlib test_multiprocessing_main_handling test_py_compile test_pydoc test_runpy
  - pydoc: test_enum
- inspect: test_abc test_asyncgen test_buffer test_builtin test_code test_collections test_coroutines test_decimal test_functools test_generators test_grammar test_monitoring test_ntpath test_operator test_patma test_posixpath test_signal test_sqlite3 test_traceback test_type_annotations test_types test_typing test_unittest test_yield_from test_zipimport test_zoneinfo
  - ast: test_ast test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_site test_ssl test_type_comments test_ucn
  - bdb: test_bdb
  - cmd: test_cmd
  - dataclasses: test__colorize test_copy test_ctypes test_genericalias test_pprint test_regrtest
  - pkgutil: test_pkgutil
  - rlcompleter: test_rlcompleter
  - trace: test_trace
  - xmlrpc.server: test_docxmlrpc test_xmlrpc
- linecache:
  - timeit: test_timeit
  - traceback: test_asyncio test_code_module test_contextlib test_contextlib_async test_dictcomps test_exceptions test_http_cookiejar test_importlib test_iter test_listcomps test_pyexpat test_setcomps test_socket test_subprocess test_sys test_threadedtempfile test_threading test_unittest test_with
- traceback:
  - concurrent.futures.process: test_concurrent_futures
  - http.cookiejar: test_urllib2
  - logging: test_asyncio test_hashlib test_logging test_support test_urllib2net
  - multiprocessing: test_asyncio test_concurrent_futures test_fcntl test_memoryview test_re
  - socketserver: test_imaplib test_socketserver test_wsgiref
  - threading: test_android test_asyncio test_bz2 test_concurrent_futures test_ctypes test_email test_fork1 test_frame test_ftplib test_gc test_httplib test_httpservers test_importlib test_io test_itertools test_largefile test_opcache test_pathlib test_poll test_poplib test_queue test_robotparser test_sched test_smtplib test_super test_syslog test_termios test_threading_local test_time test_urllib2_localnet test_weakref test_winreg test_zstd

[ ] lib: cpython/Lib/trace.py
[ ] test: cpython/Lib/test/test_trace.py (TODO: 14)

dependencies:

trace (native: main, gc, sys, time)
- sysconfig (native: _sysconfig, _winapi, importlib.machinery, importlib.util, os.path, sys)
- pickle, tokenize
- argparse, dis, inspect, io, linecache, os, runpy, threading, token

dependent tests: (1 tests)

trace: test_trace

[ ] test: cpython/Lib/test/test_tuple.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on tuple)

[x] lib: cpython/Lib/types.py
[ ] test: cpython/Lib/test/test_types.py (TODO: 10)

dependencies:

types

dependent tests: (52 tests)

types: test_annotationlib test_ast test_asyncgen test_asyncio test_builtin test_call test_code test_collections test_compile test_compiler_assemble test_coroutines test_decorators test_descr test_dis test_doctest test_dtrace test_dynamicclassattribute test_email test_enum test_exception_group test_fstring test_funcattrs test_generators test_genericalias test_hmac test_importlib test_inspect test_listcomps test_marshal test_monitoring test_opcache test_os test_positional_only_arg test_pprint test_pyclbr test_pydoc test_raise test_string test_subclassinit test_subprocess test_tempfile test_threading test_trace test_traceback test_type_aliases test_type_annotations test_type_params test_types test_typing test_unittest test_xml_etree test_xml_etree_c

[ ] test: cpython/Lib/test/test_utf8source.py (TODO: 2)

dependencies:

dependent tests: (no tests depend on utf8source)

[x] lib: cpython/Lib/weakref.py
[x] lib: cpython/Lib/_weakrefset.py
[x] test: cpython/Lib/test/test_weakref.py (TODO: 21)
[ ] test: cpython/Lib/test/test_weakset.py

dependencies:

weakref

dependent tests: (204 tests)

weakref: test_array test_ast test_asyncio test_code test_concurrent_futures test_context test_contextlib test_copy test_ctypes test_deque test_descr test_dict test_enum test_exceptions test_file test_fileio test_frame test_functools test_gc test_generators test_genericalias test_importlib test_inspect test_io test_ipaddress test_itertools test_logging test_memoryio test_memoryview test_mmap test_ordered_dict test_pickle test_picklebuffer test_queue test_re test_scope test_set test_slice test_socket test_sqlite3 test_ssl test_struct test_sys test_tempfile test_thread test_threading test_threading_local test_type_params test_types test_typing test_unittest test_uuid test_weakref test_weakset test_xml_etree
- asyncio: test_asyncio test_contextlib_async test_os test_sys_settrace test_unittest
- bdb: test_bdb
- concurrent.futures.process: test_compileall test_concurrent_futures
- copy: test_bytes test_codecs test_collections test_copyreg test_coroutines test_csv test_decimal test_defaultdict test_dictviews test_email test_fractions test_http_cookies test_minidom test_opcache test_optparse test_platform test_plistlib test_posix test_site test_statistics test_sysconfig test_tomllib test_urllib2 test_xml_dom_minicompat test_zlib
  - argparse: test_argparse
  - collections: test_annotationlib test_bisect test_builtin test_c_locale_coercion test_call test_configparser test_contains test_ctypes test_exception_group test_fileinput test_funcattrs test_hash test_httpservers test_iter test_iterlen test_json test_math test_monitoring test_pathlib test_patma test_pprint test_pydoc test_random test_reprlib test_richcmp test_shelve test_sqlite3 test_string test_traceback test_tuple test_urllib test_userdict test_userlist test_userstring test_with
  - dataclasses: test__colorize test_ctypes test_regrtest test_zoneinfo
  - email.generator: test_email
  - gettext: test_gettext test_tools
  - http.cookiejar: test_http_cookiejar
  - http.server: test_robotparser test_urllib2_localnet test_xmlrpc
  - logging.handlers: test_pkgutil
  - mailbox: test_mailbox
  - smtplib: test_smtplib test_smtpnet
  - tarfile: test_shutil test_tarfile
  - webbrowser: test_webbrowser
- inspect: test_abc test_asyncgen test_buffer test_grammar test_ntpath test_operator test_posixpath test_signal test_type_annotations test_yield_from test_zipimport
  - ast: test_compile test_compiler_codegen test_dis test_fstring test_future_stmt test_type_comments test_ucn test_unparse
  - cmd: test_cmd
  - importlib.metadata: test_importlib
  - pkgutil: test_runpy
  - rlcompleter: test_rlcompleter
  - trace: test_trace
- logging: test_hashlib test_support test_urllib2net
  - hashlib: test_hmac test_unicodedata
  - multiprocessing.util: test_concurrent_futures
  - venv: test_venv
- multiprocessing: test_fcntl test_multiprocessing_main_handling
- symtable: test_symtable
- tempfile: test_bz2 test_cmd_line test_ctypes test_doctest test_ensurepip test_faulthandler test_filecmp test_importlib test_launcher test_linecache test_modulefinder test_pkg test_py_compile test_selectors test_string_literals test_subprocess test_tabnanny test_termios test_threadedtempfile test_urllib_response test_winconsoleio test_zipapp test_zipfile test_zipfile64 test_zstd
  - ctypes.util: test_ctypes
  - urllib.request: test_sax test_urllibnet

[x] lib: cpython/Lib/xml
[x] test: cpython/Lib/test/test_xml_etree.py (TODO: 61)
[ ] test: cpython/Lib/test/test_xml_etree_c.py
[x] test: cpython/Lib/test/test_minidom.py (TODO: 25)
[x] test: cpython/Lib/test/test_pulldom.py (TODO: 4)
[x] test: cpython/Lib/test/test_pyexpat.py (TODO: 29)
[x] test: cpython/Lib/test/test_sax.py (TODO: 39)
[x] test: cpython/Lib/test/test_xml_dom_minicompat.py
[x] test: cpython/Lib/test/test_xml_dom_xmlbuilder.py

dependencies:

xml

dependent tests: (34 tests)

xml: test_doctest test_minidom test_pulldom test_pydoc test_pyexpat test_regrtest test_sax test_typing test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml_etree
- plistlib: test_plistlib
  - platform: test__locale test__osx_support test_android test_asyncio test_baseexception test_builtin test_cmath test_ctypes test_fcntl test_math test_mimetypes test_os test_platform test_posix test_shutil test_socket test_ssl test_sysconfig test_time test_winreg test_wsgiref
- xmlrpc.client: test_xmlrpc

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/vm/src/builtins/classmethod.rs`:
- Around line 60-61: The existing comment above the line `let callable =
zelf.callable.lock().clone();` in descr_get is now inaccurate because this path
no longer calls Python code; update or remove the comment so it no longer states
“before calling Python code.” Replace it with a concise factual note such as
“Clone the callable and release the lock to avoid holding the lock across
subsequent operations” or simply delete the comment to avoid misleading future
readers; ensure the reference to `zelf.callable.lock().clone()` remains so
reviewers can find the changed line.

ℹ️ Review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ce0f0549-61ab-4a27-80a4-7bf51010cc55

📥 Commits

Reviewing files that changed from the base of the PR and between 073adbd and 5280922.

⛔ Files ignored due to path filters (1)

Lib/test/test_decorators.py is excluded by !Lib/**

📒 Files selected for processing (1)

crates/vm/src/builtins/classmethod.rs

Simplify classmethod.__get__ to always create a PyBoundMethod binding the callable to the class, matching CPython's cm_descr_get which simply calls PyMethod_New(cm->cm_callable, type). The previous implementation incorrectly tried to call __get__ on the wrapped callable, which broke when a bound method was passed to classmethod() (e.g. classmethod(A().foo)).

👍🏻

👍

Simplify classmethod.__get__ to always create a PyBoundMethod binding the callable to the class, matching CPython's cm_descr_get which simply calls PyMethod_New(cm->cm_callable, type). The previous implementation incorrectly tried to call __get__ on the wrapped callable, which broke when a bound method was passed to classmethod() (e.g. classmethod(A().foo)).

ever0de force-pushed the fix-classmethod-bound-method branch from d282d76 to 5280922 Compare March 13, 2026 13:51

ever0de marked this pull request as ready for review March 13, 2026 14:00

coderabbitai Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread crates/vm/src/builtins/classmethod.rs Outdated

ever0de force-pushed the fix-classmethod-bound-method branch from 5280922 to aa16500 Compare March 13, 2026 14:18

moreal approved these changes Mar 13, 2026

View reviewed changes

youknowone approved these changes Mar 13, 2026

View reviewed changes

youknowone merged commit 7d63f65 into RustPython:main Mar 13, 2026
16 checks passed

coderabbitai Bot mentioned this pull request Mar 20, 2026

Improve CPython compatibility related with PyBoundMethod #7476

Merged

Fix classmethod descr_get to match CPython behavior by ever0de · Pull Request #7420 · RustPython/RustPython · GitHub

Uh oh!

Fix classmethod descr_get to match CPython behavior - #7420

Fix classmethod descr_get to match CPython behavior#7420
youknowone merged 1 commit into
RustPython:mainfrom
ever0de:fix-classmethod-bound-method

ever0de commented Mar 13, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 13, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Mar 13, 2026 •
edited
Loading

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

moreal left a comment

Uh oh!

youknowone left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix classmethod descr_get to match CPython behavior by ever0de · Pull Request #7420 · RustPython/RustPython · GitHub

Uh oh!

Fix classmethod descr_get to match CPython behavior - #7420

Fix classmethod descr_get to match CPython behavior#7420youknowone merged 1 commit intoRustPython:mainRustPython/RustPython:mainfrom ever0de:fix-classmethod-bound-methodever0de/RustPython:fix-classmethod-bound-methodCopy head branch name to clipboard

Conversation

ever0de commented Mar 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CPython reference

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Library Dependencies

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moreal left a comment

Choose a reason for hiding this comment

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix classmethod descr_get to match CPython behavior#7420
youknowone merged 1 commit into
RustPython:mainfrom
ever0de:fix-classmethod-bound-method

ever0de commented Mar 13, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Mar 13, 2026 •
edited
Loading

github-actions Bot commented Mar 13, 2026 •
edited
Loading