Handle EINTR retry in os.write() (PEP 475) by youknowone · Pull Request #7482 · RustPython/RustPython · GitHub

Add EINTR retry loop to os.write(), matching the existing pattern in os.read() and os.readinto(). Remove the expectedFailure marker from test_write in _test_eintr.py.

Summary by CodeRabbit

Bug Fixes
- Enhanced reliability of file write operations by properly handling signal interruption.
Refactor
- Improved performance of dictionary element extraction operations.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 03589555-5d90-46d7-963c-06bb740d03a6

📥 Commits

Reviewing files that changed from the base of the PR and between 372280e and b2aef25.

⛔ Files ignored due to path filters (2)

Lib/test/_test_eintr.py is excluded by !Lib/**
Lib/test/_test_multiprocessing.py is excluded by !Lib/**

📒 Files selected for processing (2)

crates/vm/src/stdlib/os.rs
crates/vm/src/vm/mod.rs

📝 Walkthrough

Walkthrough

Updated the write function in os._os to handle EINTR errors with retry logic via signal checks, and added fast-path optimizations in VirtualMachine::extract_elements_with for dict-like inputs using snapshot methods.

Changes

Cohort / File(s)	Summary
EINTR Handling in OS Write crates/vm/src/stdlib/os.rs	Modified os._os.write to return PyResult<usize> instead of io::Result<usize>. Added logic to retry on EINTR errors by calling vm.check_signals()? and continuing the write loop, while converting non-EINTR errors to Python exceptions via e.into_pyexception(vm).
Dict Fast Paths in VirtualMachine crates/vm/src/vm/mod.rs	Added type-specific fast paths in extract_elements_with for dict-like inputs (dict, dict_keys_type, dict_values_type). Uses snapshot methods (keys_vec(), values_vec()) for atomic extraction. Imported PyDictKeys to enable downcasting for dict keys branch.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

update _pyio, test_fileio from 3.13.11 and impl more io features #6560: Implements EINTR-aware retry semantics for stdlib write operations, converting low-level IO errors to Python exceptions.
Fix EINTR handling #7204: Adds EINTR retry handling for low-level write operations in the io.rs module with similar error-conversion patterns.
new_last_{os,errno}_error #6381: Modifies error-to-Python-exception handling in os.rs, including IntoPyException and errno error helpers that this PR depends on.

Poem

🐰 A signal knocks upon the write,
We pause and check, then hoist to height,
Dict keys snapshot, swift and lean,
Fast paths dance—the cleanest seen,
Errors caught, no more to fight! 🏃‍♂️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'Handle EINTR retry in os.write() (PEP 475)' directly and specifically describes the primary change in the changeset, which updates the os.write() function to handle EINTR interrupts with proper retry logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add EINTR retry loop to os.write(), matching the existing pattern in os.read() and os.readinto(). Remove the expectedFailure marker from test_write in _test_eintr.py.

Add fast paths for dict and dict_keys types in extract_elements_with, matching _list_extend() in CPython Objects/listobject.c. Each branch takes an atomic snapshot under a single read lock, preventing race conditions from concurrent dict mutation without the GIL. Remove expectedFailure from test_thread_safety.

* Handle EINTR retry in os.write() (PEP 475) Add EINTR retry loop to os.write(), matching the existing pattern in os.read() and os.readinto(). Remove the expectedFailure marker from test_write in _test_eintr.py. * Add atomic snapshot for dict/dict_keys in extract_elements Add fast paths for dict and dict_keys types in extract_elements_with, matching _list_extend() in CPython Objects/listobject.c. Each branch takes an atomic snapshot under a single read lock, preventing race conditions from concurrent dict mutation without the GIL. Remove expectedFailure from test_thread_safety.

youknowone force-pushed the eintr branch from 301b4d6 to 00129ea Compare March 23, 2026 06:31

youknowone added 2 commits March 25, 2026 11:58

Handle EINTR retry in os.write() (PEP 475)

5b77f1d

Add EINTR retry loop to os.write(), matching the existing pattern in os.read() and os.readinto(). Remove the expectedFailure marker from test_write in _test_eintr.py.

youknowone force-pushed the eintr branch from 00129ea to b2aef25 Compare March 25, 2026 02:58

youknowone marked this pull request as ready for review March 25, 2026 04:56

youknowone merged commit 6b5c5a9 into RustPython:main Mar 25, 2026
19 checks passed

youknowone deleted the eintr branch March 25, 2026 05:02

Handle EINTR retry in os.write() (PEP 475) by youknowone · Pull Request #7482 · RustPython/RustPython · GitHub

Uh oh!

Handle EINTR retry in os.write() (PEP 475) - #7482

Handle EINTR retry in os.write() (PEP 475)#7482
youknowone merged 2 commits into
RustPython:mainfrom
youknowone:eintr

youknowone commented Mar 23, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Handle EINTR retry in os.write() (PEP 475) by youknowone · Pull Request #7482 · RustPython/RustPython · GitHub

Uh oh!

Handle EINTR retry in os.write() (PEP 475) - #7482

Handle EINTR retry in os.write() (PEP 475)#7482youknowone merged 2 commits intoRustPython:mainRustPython/RustPython:mainfrom youknowone:eintryouknowone/RustPython:eintrCopy head branch name to clipboard

Conversation

youknowone commented Mar 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Handle EINTR retry in os.write() (PEP 475)#7482
youknowone merged 2 commits into
RustPython:mainfrom
youknowone:eintr

youknowone commented Mar 23, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading