Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

crates/stdlib/src/json.rs (1)

167-183: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Keep parse_constant callback arguments as strings.

Line 172 now forwards b"NaN"/b"Infinity"/b"-Infinity" into self.parse_constant.call(...), so this path passes Python bytes instead of the str tokens that call_scan_once still uses at Lines 594, 599, and 605. That breaks the callback contract for these constants depending on which scanner path is taken.

Proposed fix

             macro_rules! parse_constant {
-                ($s:literal) => {
-                    if rest.starts_with($s) {
+                ($bytes:literal, $token:literal) => {
+                    if rest.starts_with($bytes) {
                         return Ok(PyIterReturn::Return(
                             vm.new_tuple((
-                                self.parse_constant.call(($s,), vm)?,
-                                char_idx + $s.len(),
+                                self.parse_constant.call(($token,), vm)?,
+                                char_idx + $bytes.len(),
                             ))
                             .into(),
                         ));
                     }
                 };
             }

-            parse_constant!(b"NaN");
-            parse_constant!(b"Infinity");
-            parse_constant!(b"-Infinity");
+            parse_constant!(b"NaN", "NaN");
+            parse_constant!(b"Infinity", "Infinity");
+            parse_constant!(b"-Infinity", "-Infinity");

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/stdlib/src/json.rs` around lines 167 - 183, The parse_constant
callback in json scanning is receiving bytes for NaN/Infinity/-Infinity, which
breaks the existing string-based contract. Update the constant parsing path in
the macro in json.rs so `self.parse_constant.call(...)` is passed string tokens
instead of byte literals, matching the `call_scan_once` paths and keeping
`parse_constant` consistent across all scanner entry points.