Repository navigation
Fix clippy warning - #8249
Fix clippy warning#8249youknowone merged 3 commits into
Conversation
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 6af43a95-4f07-4a61-9c03-a1eabeca40d9 📥 CommitsReviewing files that changed from the base of the PR and between 3a6a3ac and d3f79d5. 📒 Files selected for processing (4)
📝 Walkthrough WalkthroughThis PR simplifies Rust AST pattern matching, option/error control flow, formatting arguments, and Clippy annotations across codegen, VM, standard-library, host-environment, derive, and entry-point code without changing public declarations. ChangesRust cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ShaharNaveh, coolreader18 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
|
The following error might be a bug in the latest stable rust. As it requires a unstable feature. error: used import from `std` instead of `core`
--> crates/host_env/src/fileutils.rs:468:13
|
468 | std::io::ErrorKind::InvalidInput,
| ^^^ help: consider importing the item from `core`: `core`
|
Sorry, something went wrong.
I was going to suggest reporting it to https://github.com/rust-lang/rust-clippy/issues, but this might be a duplicate of rust-lang/rust-clippy#15836. |
Sorry, something went wrong.
ShaharNaveh
left a comment
There was a problem hiding this comment.
ty:)
Sorry, something went wrong.
|
Forgot to say, I think it will be better for us to pin the channel at https://github.com/RustPython/RustPython/blob/main/rust-toolchain.toml to a specific version, like 1.96 for now. It's not ideal for us to have the CI break every couple of months every time a new stable version releases |
Sorry, something went wrong.
- exceptions.rs: {b:#02x} -> {b:#04x} (unused_format_specs); output
unchanged for decode-error bytes (always >= 0x80)
- binascii.rs: [b'\r', b'\n'] -> b"\r\n" (byte_str_slice)
- host_env, _io.rs, ssl.rs, pyexpat.rs: expect std_instead_of_core where
the suggested core::io items (ErrorKind, Cursor) are unstable (core_io);
use expect so the suppression is flagged for removal once core::io
stabilizes. build_posix_spawn_attrs co-gates the expect with the cfg
block so it is not left unfulfilled on platforms compiling it out.
Assisted-by: Claude
| // _Py_fopen_obj in cpython (Python/fileutils.c:1757-1835) | ||
| // Open a file using std::fs::File and convert to FILE* | ||
| // Automatically handles path encoding and EINTR retries | ||
| #[expect(clippy::std_instead_of_core)] // false positive: core::io::ErrorKind is unstable (core_io) |
There was a problem hiding this comment.
Can you convert those to #[expect(..., reason="...")] please
Sorry, something went wrong.
ShaharNaveh
left a comment
There was a problem hiding this comment.
thanks!
Sorry, something went wrong.
* Fix clippy warning
* Fix clippy warnings surfaced by newer clippy
- exceptions.rs: {b:#02x} -> {b:#04x} (unused_format_specs); output
unchanged for decode-error bytes (always >= 0x80)
- binascii.rs: [b'\r', b'\n'] -> b"\r\n" (byte_str_slice)
- host_env, _io.rs, ssl.rs, pyexpat.rs: expect std_instead_of_core where
the suggested core::io items (ErrorKind, Cursor) are unstable (core_io);
use expect so the suppression is flagged for removal once core::io
stabilizes. build_posix_spawn_attrs co-gates the expect with the cfg
block so it is not left unfulfilled on platforms compiling it out.
Assisted-by: Claude
* Fix more
---------
Co-authored-by: Jeong YunWon <jeong@youknowone.org>
Summary by CodeRabbit