I haven't realized it duplicated like that. tysm!

Actionable comments posted: 2

crates/vm/src/stdlib/time.rs (1)

571-578: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use a helper closure to deduplicate the ASCII buffer flush logic.

The logic for flushing ascii to out is duplicated three times. Consider extracting it into a closure to improve maintainability.

♻️ Proposed refactor

         let mut out = Wtf8Buf::new();
         let mut ascii = String::new();
 
+        let mut flush_ascii = |ascii: &mut String, out: &mut Wtf8Buf| -> PyResult<()> {
+            if !ascii.is_empty() {
+                let part =
+                    host_time::strftime_ascii(ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
+                out.extend(part.chars());
+                ascii.clear();
+            }
+            Ok(())
+        };
+
         for codepoint in format.as_wtf8().code_points() {
             if codepoint.to_u32() == 0 {
-                if !ascii.is_empty() {
-                    let part =
-                        host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-                    out.extend(part.chars());
-                    ascii.clear();
-                }
+                flush_ascii(&mut ascii, &mut out)?;
                 out.push(codepoint);
                 continue;
             }
             if let Some(ch) = codepoint.to_char()
                 && ch.is_ascii()
             {
                 ascii.push(ch);
                 continue;
             }
 
-            if !ascii.is_empty() {
-                let part =
-                    host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-                out.extend(part.chars());
-                ascii.clear();
-            }
+            flush_ascii(&mut ascii, &mut out)?;
             out.push(codepoint);
         }
-        if !ascii.is_empty() {
-            let part = host_time::strftime_ascii(&ascii, &tm).map_err(|e| e.to_pyexception(vm))?;
-            out.extend(part.chars());
-        }
+        flush_ascii(&mut ascii, &mut out)?;
         Ok(out.to_pyobject(vm))

Also applies to: 589-598

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/vm/src/stdlib/time.rs` around lines 571 - 578, In the time-formatting
loop, extract the repeated non-empty `ascii` buffer flush into a local helper
closure that calls `host_time::strftime_ascii`, extends `out`, and clears
`ascii`; replace all three duplicated flush blocks with this closure while
preserving error propagation and existing output behavior.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/vm/src/stdlib/nt.rs`:
- Line 555: Update the error return in the null-character handling path to call
nul_char_error through its fully qualified exceptions module path and pass the
in-scope vm argument.

In `@crates/vm/src/stdlib/winsound.rs`:
- Line 145: Update the error return in the winsound function to reference the
exceptions module through its fully qualified path, preserving the existing
nul_char_error(vm) behavior without adding an import.

---

Nitpick comments:
In `@crates/vm/src/stdlib/time.rs`:
- Around line 571-578: In the time-formatting loop, extract the repeated
non-empty `ascii` buffer flush into a local helper closure that calls
`host_time::strftime_ascii`, extends `out`, and clears `ascii`; replace all
three duplicated flush blocks with this closure while preserving error
propagation and existing output behavior.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9bbc6a49-f35c-4f0b-b376-cd49a5c8e422

Reviewing files that changed from the base of the PR and between cc30cd5 and 31b6e13.

• crates/stdlib/src/grp.rs
• crates/stdlib/src/multiprocessing.rs
• crates/stdlib/src/openssl.rs
• crates/stdlib/src/ssl.rs
• crates/vm/src/buffer.rs
• crates/vm/src/exceptions.rs
• crates/vm/src/function/fspath.rs
• crates/vm/src/stdlib/_codecs.rs
• crates/vm/src/stdlib/_io.rs
• crates/vm/src/stdlib/nt.rs
• crates/vm/src/stdlib/os.rs
• crates/vm/src/stdlib/pwd.rs
• crates/vm/src/stdlib/time.rs
• crates/vm/src/stdlib/winsound.rs
• crates/vm/src/utils.rs

great, looking a lot better. thank you!