FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop the last two lint expectations clippy 1.98 no longer fulfils by luantaraschi · Pull Request #8568 · RustPython/RustPython · GitHub

Drop the last two lint expectations clippy 1.98 no longer fulfils - #8568

Merged
youknowone merged 1 commit into
RustPython:mainfrom
luantaraschi:fix/signal-stale-lint-expectation
Aug 21, 2026
Merged

Drop the last two lint expectations clippy 1.98 no longer fulfils#8568
youknowone merged 1 commit into
RustPython:mainfrom
luantaraschi:fix/signal-stale-lint-expectation

Conversation

luantaraschi commented Aug 21, 2026
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor
  • I did not use AI to write the code of this patch.
  • This PR follows our AI policy

Summary

#8564 removed four #[expect(clippy::std_instead_of_core)] that clippy 1.98 stopped
fulfilling. Two more were left behind, and each hid behind a cfg that the job which
would have reported it did not compile.

crates/vm/src/stdlib/_signal.rs is gated on #[cfg(windows)], so only the Windows job
sees it. It showed up on #8564's own last run, once the other four were gone:

error: this lint expectation is unfulfilled
   --> crates\vm\src\stdlib\_signal.rs:341:13
    = note: false positive: core::io::ErrorKind is unstable (core_io)

crates/host_env/src/posix.rs is gated on not(any(linux, haiku, solaris, illumos, hurd)),
so among the CI runners only macOS compiles it. It stayed quiet until #8564 landed because
clippy reports one error per crate, and the fopen expectation in the same crate came
first. It surfaced on main right after the merge:

error: this lint expectation is unfulfilled
   --> crates/host_env/src/posix.rs:1410:13

Only the attributes go; the cfg on each statement stays.

Testing

cargo fmt --check and the workspace clippy with the flags from the CI job both pass on
Linux, so the side that was already green is undisturbed. I do not have a Rust toolchain on
Windows or macOS, so I did not reproduce either of those two jobs myself. The quoted errors
are from your CI rather than from my machine, and your CI is what will confirm the fix.

AI assistance

Claude Code (claude-opus-5) was used throughout: reading the CI logs to locate the two
expectations, making the deletions, and running fmt and clippy on Linux. I reviewed the
diff and the policy before opening this.

Summary by CodeRabbit

  • Chores
    • Removed unnecessary code-quality suppressions from Windows-specific and POSIX platform implementations.
    • No user-visible behavior or functionality changed.

coderabbitai Bot commented Aug 21, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 518fc8d1-04ff-404a-88ed-9f582d5153e9

📥 Commits

Reviewing files that changed from the base of the PR and between a545eef and 212318f.

📒 Files selected for processing (1)
  • crates/host_env/src/posix.rs
💤 Files with no reviewable changes (1)
  • crates/host_env/src/posix.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The change removes clippy::std_instead_of_core expectations from two platform-specific code paths. Runtime behavior and public declarations remain unchanged.

Changes

Clippy lint cleanup

Layer / File(s) Summary
Remove Clippy expectations
crates/vm/src/stdlib/_signal.rs, crates/host_env/src/posix.rs
The Windows-specific wakeup-fd code and unsupported setsid branch remove Clippy expectations and retain their existing behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 21231

This PR removes two obsolete lint expectations while leaving the guarded code unchanged, so it does not alter product behavior. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes removing the two obsolete lint expectations due to Clippy 1.98 no longer fulfilling them.
✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

luantaraschi force-pushed the fix/signal-stale-lint-expectation branch from a545eef to 2c0715f Compare August 21, 2026 07:57
luantaraschi force-pushed the fix/signal-stale-lint-expectation branch from 2c0715f to 212318f Compare August 21, 2026 07:57
luantaraschi changed the title Drop the Windows-only lint expectation clippy 1.98 no longer fulfils Drop the last two lint expectations clippy 1.98 no longer fulfils Aug 21, 2026
youknowone enabled auto-merge (squash) August 21, 2026 08:15
youknowone merged commit b917e96 into RustPython:main Aug 21, 2026
27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL