| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 518fc8d1-04ff-404a-88ed-9f582d5153e9 📥 CommitsReviewing files that changed from the base of the PR and between a545eef and 212318f. 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 Walkthrough WalkthroughThe change removes clippy::std_instead_of_core expectations from two platform-specific code paths. Runtime behavior and public declarations remain unchanged. ChangesClippy lint cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to 21231 This PR removes two obsolete lint expectations while leaving the guarded code unchanged, so it does not alter product behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Assisted-by: Claude Code:claude-opus-5
| Back | FazBrowse Home | New Git URL |
Summary
#8564 removed four #[expect(clippy::std_instead_of_core)] that clippy 1.98 stopped
fulfilling. Two more were left behind, and each hid behind a cfg that the job which
would have reported it did not compile.
crates/vm/src/stdlib/_signal.rs is gated on #[cfg(windows)], so only the Windows job
sees it. It showed up on #8564's own last run, once the other four were gone:
error: this lint expectation is unfulfilled --> crates\vm\src\stdlib\_signal.rs:341:13 = note: false positive: core::io::ErrorKind is unstable (core_io)crates/host_env/src/posix.rs is gated on not(any(linux, haiku, solaris, illumos, hurd)),
so among the CI runners only macOS compiles it. It stayed quiet until #8564 landed because
clippy reports one error per crate, and the fopen expectation in the same crate came
first. It surfaced on main right after the merge:
Only the attributes go; the cfg on each statement stays.
Testing
cargo fmt --check and the workspace clippy with the flags from the CI job both pass on
Linux, so the side that was already green is undisturbed. I do not have a Rust toolchain on
Windows or macOS, so I did not reproduce either of those two jobs myself. The quoted errors
are from your CI rather than from my machine, and your CI is what will confirm the fix.
AI assistance
Claude Code (claude-opus-5) was used throughout: reading the CI logs to locate the two
expectations, making the deletions, and running fmt and clippy on Linux. I reviewed the
diff and the policy before opening this.
Summary by CodeRabbit