Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 7e07d003-c65f-4c4e-ba93-26cb9b4ad5b3

Reviewing files that changed from the base of the PR and between a7d75d2 and 09fbaad.

• crates/derive-impl/src/pyclass.rs
• crates/derive/src/lib.rs
• crates/vm/src/builtins/dict.rs
• crates/vm/src/object/core.rs
• crates/vm/src/object/payload.rs
• crates/vm/src/stdlib/_io.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The pyclass derive macro now checks native subclass field offsets, payload offsets, and object alignment. BASICSIZE uses payload layout, PyDict and _IOBase have 8-byte alignment, and tests cover aligned payload size and inherited and derived getters.

Changes

Native subclass layout

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: youknowone

Merge Risk: ⚪ Minimal · up to 09fba

No identified layout or allocation issue blocks merging. The compile-fail examples and wasm32 behavior remain unexecuted in the supplied evidence.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 09fba

The new checks appear to prevent incompatible native subclass layouts rather than expose a new runtime entry point. The change still warrants review because it can affect which native subclasses build and how their size is reported, particularly across target architectures.

Retained concerns
No architecture-level concerns identified.

Security Blast Radius

• inferred — The affected exposure is native Rust subclass layout and VM class metadata, including the aligned dictionary and I/O bases; no tenant, credential, or network boundary change is established.

Trust Boundaries and Controls

• observed — For a declared native base, generated constants check the base-field address, payload address, and object alignment at compile time.

Resilience and Maintainability Implications

• inferred — The full typed Py layout remains the allocation and deallocation basis, countering an inference that the changed BASICSIZE alone reduces allocated object memory.

Hardening Proposals

• proposed — Exercise native-subclass compile-fail and size behavior on both 32-bit and 64-bit targets to detect target-specific layout drift before release.

❌ Failed checks (1 warning)

• Fix all pre-merge checks with AI

• Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

• X
• Mastodon
• Reddit
• LinkedIn

Comment @coderabbitai help to get the list of available commands.

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1

Comparing 1ndahous3:pyclass_payload_layout (09fbaad) with main (a7d75d2)

Footnotes

1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩