cf-java-logging-support Bill of Materials (BOM) added - #415
Open
aamotharald wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
KarstenSchnitter
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for providing this PR. I agree that a BOM is a useful addition to the library making it easier to consume. I have some proposals to the PR.
Sorry, something went wrong.
Comment thread
cf-java-logging-support-bom/pom.xml
Comment on lines
+44
to
+49
| <!-- unclear if this is good to manage, as it is mainly agent/runtime-extension specific --> | ||
| <dependency> | ||
| <groupId>com.sap.hcp.cf.logging</groupId> | ||
| <artifactId>cf-java-logging-support-opentelemetry-agent-extension</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This should not be managed in the BOM. It is a separate extension with a different use-case.
Suggested change
| <!-- unclear if this is good to manage, as it is mainly agent/runtime-extension specific --> | |
| <dependency> | |
| <groupId>com.sap.hcp.cf.logging</groupId> | |
| <artifactId>cf-java-logging-support-opentelemetry-agent-extension</artifactId> | |
| <version>${project.version}</version> | |
| </dependency> |
Sorry, something went wrong.
Comment thread
README.md
| </dependencyManagement> | ||
| ``` | ||
|
|
||
| Then you can control the version of all features by just changing the property `cf-java-logging-support.version` in your POM an omitting any version in your `cf-java-logging-support` dependencies. Please note that our BOM manages solely the versions of the `cf-java-logging-support` features, but not the versions of the logging implementation backends or other used libraries (e.g. logback or log4j2). |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| Then you can control the version of all features by just changing the property `cf-java-logging-support.version` in your POM an omitting any version in your `cf-java-logging-support` dependencies. Please note that our BOM manages solely the versions of the `cf-java-logging-support` features, but not the versions of the logging implementation backends or other used libraries (e.g. logback or log4j2). | |
| You can control the version of all features by just changing the property `cf-java-logging-support.version` in your POM an omitting any version in your `cf-java-logging-support` dependencies. Please note that our BOM manages solely the versions of the `cf-java-logging-support` features, but not the versions of the logging implementation backends or other used libraries (e.g. logback or log4j2). |
Sorry, something went wrong.
Comment thread
cf-java-logging-support-bom/pom.xml
|
|
||
| <artifactId>cf-java-logging-support-bom</artifactId> | ||
| <packaging>pom</packaging> | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Let's add a specific description.
Suggested change
| <description>Bill of Materials for cf-java-logging-support dependencies</description> |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @KarstenSchnitter ,
I am proposing this to make consumption via starters or parents in bigger projects easier.
Let me know your thoughts on this.
See Feature Request #417 417