FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Configuration needed to use IAS and SMS by davidhunglam · Pull Request #382 · SAP-samples/cloud-cap-samples-java · GitHub

/ cloud-cap-samples-java Public

Configuration needed to use IAS and SMS - #382

Draft
davidhunglam wants to merge 5 commits into
mainfrom
identity
ConversationCommits (5)ChecksFiles changed
Draft

Configuration needed to use IAS and SMS#382
davidhunglam wants to merge 5 commits into
mainfrom
identity

Conversation

davidhunglam commented Oct 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR only to review the changes, we'll keep the identity branch. It's not supposed to be merged to main!

davidhunglam changed the title Configuration needed for using IAS and SMS Configuration needed to use IAS and SMS Oct 17, 2024
davidhunglam marked this pull request as draft October 17, 2024 12:45
davidhunglam added the ☠️ do not merge ☠️ Do not merge PR label Oct 17, 2024

davidhunglam commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

PR only to review the changes, we'll keep the identity branch. It's not supposed to be merged to main!

StefanHenke reviewed Oct 18, 2024
View reviewed changes
Comment thread mta-multi-tenant.yaml Outdated
Comment thread mta-multi-tenant.yaml Outdated
Comment thread mta-multi-tenant.yaml
Comment thread mta-multi-tenant.yaml

StefanHenke Oct 18, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In other branches like for messaging, we kept the mta-multi-tenant.yaml and added a separate one mta-multi-tenant-messaging.yaml. Should we stick to that pattern?

BraunMatthias Oct 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Dedicated mta files would be the preferred solution to demonstrate different flavours. I'd vote for mta-multi-tenant-ias-ams.yaml. We should also find a way to make this as a base for integ tests.

StefanHenke previously approved these changes Oct 18, 2024
View reviewed changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StefanHenke StefanHenke left review comments
BraunMatthias Awaiting requested review from BraunMatthias

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

☠️ do not merge ☠️ Do not merge PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL