| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for the review @izeigerman addressed comments and updated SnapshotTableInfo to keep the model gateway as you suggested which simplified the code significantly, when you have time, if you can take another look |
Sorry, something went wrong.
There was a problem hiding this comment.
very nice 👍
Sorry, something went wrong.
There was a problem hiding this comment.
Great work!
Sorry, something went wrong.
| if ( | ||
| default_catalog_per_gateway | ||
| and gateway_name | ||
| and (catalog := default_catalog_per_gateway.get(gateway_name)) |
There was a problem hiding this comment.
Seems like a case where we should be explicitly checking for None for the walrus.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This update adds support for managing a virtual layer per gateway, so a gateway when specified in the model will be responsible to create the views of the virtual layer as well as the physical tables. This is controlled by setting the provisionally called gateway_managed_virtual_layer flag to true in the config.
In this case the virtual layer will be created by the specific gateway instead of using the default gateway, which means that the catalog doesn't need to be shared between the gateways. Also the gateway specific catalog will be set for each corresponding model and the gateway specific variables will take precedence over global ones for the gateway-specified in the model.
The default behaviour remains unchanged when the flag is set to false or omitted from the config.