FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(postgres): randomize test username and update grant tests by sakshipatil-hue · Pull Request #5990 · SQLMesh/sqlmesh · GitHub

/ sqlmesh Public

fix(postgres): randomize test username and update grant tests - #5990

Merged
cmgoffena13 merged 2 commits into
SQLMesh:mainfrom
sakshipatil-hue:fix-postgres-grants-clean
Aug 29, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix(postgres): randomize test username and update grant tests#5990
cmgoffena13 merged 2 commits into
SQLMesh:mainfrom
sakshipatil-hue:fix-postgres-grants-clean

Conversation

sakshipatil-hue commented Aug 29, 2026 •
edited by cmgoffena13
Loading

Copy link
Copy Markdown
Contributor

Description

  • Randomizes PostgreSQL integration test usernames using a 6-character UUID hex suffix to prevent CI role collision issues.
  • Updates test_grants_plan_target_layer_physical_only and test_grants_plan_target_layer_virtual_only to utilize dynamic usernames via f-strings rather than hardcoded strings.

Test Plan

  • Verified code changes match existing dynamic test patterns in test_integration_postgres.py.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

sakshipatil-hue mentioned this pull request Aug 29, 2026
Closed
4 tasks
cmgoffena13 self-assigned this Aug 29, 2026

cmgoffena13 commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

@sakshipatil-hue -- formatting is failing. I pulled the fork and confirmed make style would fix it. Make sure that you have properly setup your repo by running make install-dev after creating a virtual environment as well, pre-commit should have caught that. Let me know once you've completed the checklist.

fix(postgres): format test_integration_postgres.py with ruff
58947c2 
Signed-off-by: sakshipatil-hue <sakshipatil8674788@gmail.com>
sakshipatil-hue force-pushed the fix-postgres-grants-clean branch from 1557673 to 58947c2 Compare August 29, 2026 19:33

sakshipatil-hue commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Hi @cmgoffena13, thanks for the feedback! I've gone ahead and formatted the target file using Ruff. The branch is updated and ready for your review whenever you have a moment.

cmgoffena13 merged commit 0317c1b into SQLMesh:main Aug 29, 2026
32 checks passed
cmgoffena13 linked an issue Aug 29, 2026 that may be closed by this pull request
CI Fix - Postgres CI Failing Sometimes #5972
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

cmgoffena13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI Fix - Postgres CI Failing Sometimes

2 participants

Back | FazBrowse Home | New Git URL