This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Add Optional Deletion Tracking To PG and MySql Stores - #281
Merged
thefringeninja merged 3 commits intoMay 23, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pgermishuys
reviewed
May 23, 2019
Comment thread
src/SqlStreamStore.MySql/MySqlStreamStoreSettings.cs
| /// performance, however subscribers won't know if a stream or a | ||
| /// message has been deleted. This can be modified at runtime. | ||
| /// </summary> | ||
| public bool DisableDeletionTracking { get; set; } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
DisableDeletionTracking sounds like an operation I can perform whereas DeletionTrackingEnabled tells me it's a property that I am able to get/ set. (sorry if this comes across as nitpicking)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Agreed, but then it would not align with what's already in there for MsSqlV3. I know that people are using the beta in production and I am reluctant to break them
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
gotcha!
Sorry, something went wrong.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with MsSql V3