SVProgressHUD should support single window apps adopting SceneDelegate - #978
Open
slizeray wants to merge 2 commits into
Open
SVProgressHUD should support single window apps adopting SceneDelegate#978slizeray wants to merge 2 commits into
slizeray wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…property on the application delegate. It make the lib compatible with apps which adopt the new Scene protocol
…ible with new scene life cycle
tanis2000
approved these changes
Jul 7, 2020
tanis2000
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
It would be nice to have this merged into a new release |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Aaaaaand? :) Will it be merged soon? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
when will this be merged? :) |
Sorry, something went wrong.
dipkasyap
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window property on the app delegate is nil when using a SceneDelegate