Add Sum Method - #51
Open
keithdoggett wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
developerfab
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I have left some comments. I have a question, what is the gem that use this project to do the tests?
Sorry, something went wrong.
Comment thread
ext/elementwise.c
| { | ||
| complex double* input_elements = (complex double*)input->elements; | ||
| complex double sum = 0 + 0*I; | ||
| for(size_t index = 0; index < input->count; index++){ |
Copy link
Copy Markdown
There was a problem hiding this comment.
I have seen that you have this cycle in each case of this condition, I think that you could move this in a function, WDYT?. Also I think that you could create a function that calcule this operation and in each case "cast" the response, but maybe this could be weird 🤔
Sorry, something went wrong.
Comment thread
ext/elementwise.c
| Data_Get_Struct(self, nmatrix, input); | ||
|
|
||
| VALUE result; | ||
|
|
Copy link
Copy Markdown
There was a problem hiding this comment.
I think that this line isn't necessary
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sum instance method in the elementwise module and associated tests in elementwise_test.