removing unused namespaces - #301
Merged
Oceania2018 merged 3 commits intoJul 23, 2019
Merged
Oceania2018 merged 3 commits into
Oceania2018 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
tests are also failing in original master branch. errors not introduced here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Johann, are you sure it will speed up the compiler ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
yes, but usually you wont't notice except in benchmarking. also the autocomplete is cleaner with fewer imports. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
also implemented explicit and implicit type conversion from scalars to tensors and tensors to scalars. |
Sorry, something went wrong.
Oceania2018
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing unused namespaces in order to speed up the compiler and static code analyzers