Use VM's serialization methods in updateAllBlocks - #9152
Merged
mxmou merged 1 commit intoAug 22, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Samq64
approved these changes
Aug 20, 2026
Samq64
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
When switching sprites comments do not update their positions instantly but that is also the case without Scratch Addons to an extent.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9151
Changes
Changes updateAllBlocks() to use the VM's methods to serialize blocks and comments instead of blockly.Xml.workspaceToDom().
Tests
Tested on Edge and Firefox.