color-picker: don't use eyedropper hack - #9160
Merged
mxmou merged 1 commit intoAug 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Samq64
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5993
Changes
Changes how the hex color picker sets the color: instead of simulating a click on the eyedropper, it now calls a method of Scratch's color picker component.
Reason for changes
The new implementation is simpler. It also fixes a bug where a user click could deactivate the eyedropper before the addon did.
Tests
Tested on Edge and Firefox.