test: add failing regression suite for property names colliding with standardized columns - #5
Open
rjurney wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…standardized columns PropertyGroup.getData appends requested properties to a fixed base projection without checking them against the aliases that same select already emits (id / property_group on vertices, src / dst / weight on edges). The duplicate survives into QueryExecutor.renameAll, which maps both copies to the same prefixed name, so the ambiguity reaches Spark. The suite documents the expected behavior -- a.id is the raw key property, distinct from the masked graph id getData derives from it. It includes two non-colliding controls plus the two aggravated shapes: a colliding property carried by a predicate (breaks the adjacency join rather than the terminal join-back) and a colliding property on an undirected group (fails inside getData's two-orientation union). Currently red: 2 of 9 pass. The failures are COLUMN_ALREADY_EXISTS from renameAll and AMBIGUOUS_REFERENCE from the undirected union -- the bug these tests describe is not yet fixed. Also reflow a GraphStatistics scaladoc paragraph to satisfy scalafmt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyGroup.getData appends requested properties to a fixed base projection without checking them against the aliases that same select already emits (id / property_group on vertices, src / dst / weight on edges). The duplicate survives into QueryExecutor.renameAll, which maps both copies to the same prefixed name, so the ambiguity reaches Spark.
The suite documents the expected behavior -- a.id is the raw key property, distinct from the masked graph id getData derives from it. It includes two non-colliding controls plus the two aggravated shapes: a colliding property carried by a predicate (breaks the adjacency join rather than the terminal join-back) and a colliding property on an undirected group (fails inside getData's two-orientation union).
Currently red: 2 of 9 pass. The failures are COLUMN_ALREADY_EXISTS from renameAll and AMBIGUOUS_REFERENCE from the undirected union -- the bug these tests describe is not yet fixed.
Also reflow a GraphStatistics scaladoc paragraph to satisfy scalafmt.