FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updating Nuget packages in some samples by brgrz · Pull Request #3 · ServiceStack/ServiceStack.UseCases · GitHub

Updating Nuget packages in some samples - #3

Open
brgrz wants to merge 1 commit into
ServiceStack:masterfrom
brgrz:master
Open

Updating Nuget packages in some samples#3
brgrz wants to merge 1 commit into
ServiceStack:masterfrom
brgrz:master

Conversation

brgrz commented May 5, 2013

Copy link
Copy Markdown

fixed two lines of code in CustomAuthenticationMvc to work with latest SS

fixed two lines of code to work with latest SS

mythz commented May 5, 2013

Copy link
Copy Markdown
Member

thx, but there's a whitespace/new-line issue that shows this pull-request has modified every file.
You might have to re-clone from master to be able to send a clean pull-request.

brgrz commented May 5, 2013

Copy link
Copy Markdown
Author

hm, here the 56 modified files are depicted fine https://github.com/mhrovatic/ServiceStack.UseCases/commit/7d961bfdddbc5c71146846106e54ff0ca8125dd8

I don't know how to do it differently. I fork a project, clone my fork with GitHub for Windows, work on it, then commit and sync. Then I did pull request from the GitHub user interface.

mythz commented May 5, 2013

Copy link
Copy Markdown
Member

If it's not already, try again with autocrlf set to off, e.g:

git config --global core.autocrlf false

If the issue still exists, can you point to the lines that have changed and I can just apply the changes on my end.

brgrz commented May 5, 2013

Copy link
Copy Markdown
Author

Demis, I ran this locally but now I don't know how to make a new commit with this setting in place and a fresh pull request. You might want to update the code yourself.

The only thing I did is update all packages besides jQuery in the Manage Nuget packages dialog window and then add

using Servicestack;

to the usings list in Account and Home controllers so that ToRequestContext() was being found.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL