Fix the issue "Get Current Session ID process from Post Purchase Extension Token" - #279
Open
jonaswebdev wants to merge 9 commits into
Open
Fix the issue "Get Current Session ID process from Post Purchase Extension Token"#279jonaswebdev wants to merge 9 commits into
jonaswebdev wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I have signed the CLA! |
Sorry, something went wrong.
rafaelstz
reviewed
Jun 16, 2023
Copy link
Copy Markdown
Author
|
Hi @rafaelstz I invited you to my repository to you have "write access", please review, thank you |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hi @jonaswebdev, I'm not part of the Shopify team, so I won't be able to approve it. |
Sorry, something went wrong.
shopify-api-php v5.1.0 updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shopify issues an incomplete token/JWT payload from Checkout::PostPurchase::ShouldRender & Checkout::PostPurchase::Render methods on the Post-Purchase Extension.
The "dest" attribute is missing on the JWT payload and should contain the shop domain, so it throws an exception on the Get Current Session ID on the OAuth Process (Class: Shopify\Auth\OAuth, Method: getCurrentSessionId).
I related more details here.
WHAT is this pull request doing?
Workaround to get the shop domain from "input_data" attribute from JWT.
Type of change
Checklist