fix: disallow string callables - #53
Merged
ramsey merged 2 commits intoMay 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ramsey
marked this pull request as ready for review
May 23, 2022 18:39
chrisl-13
approved these changes
May 23, 2022
Copy link
Copy Markdown
|
Code Climate has analyzed commit a282d76 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 97.6% (0.0% change). View more on Code Climate. |
Sorry, something went wrong.
jrode
reviewed
May 23, 2022
Comment thread
tests/Intl/MessageFormatTest.php
| public function testStringsMustNotEvaluateAsCallables(): void | ||
| { | ||
| $message = 'Hello, {firstName} {lastName}!'; | ||
| $expected = 'Hello, Ceil Floor!'; |
Copy link
Copy Markdown
There was a problem hiding this comment.
👋 😄
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've encountered some cases where the string values "max," "floor," and "tan" were passed as values to replace placeholders in formatted messages. However, since we were doing an is_callable() check on the strings, and PHP has functions with these names, FormatPHP was attempting to call the functions instead of treating them as strings that should replace the placeholders.
Since we should never call a function that is potentially provided from user input, we will disallow the use of string callables. Only array callables and Closures are allowed.
Product requirements and context
How has this been tested?
PR Checklist