fix(release): don't require version field to start a line - #1511
fix(release): don't require version field to start a line#1511John-David Dalton (jdalton) merged 2 commits into
Conversation
Sorry, something went wrong.
writeManifestVersion anchored on ^ + multiline, requiring the version field to open its own line. package.json always parses fine with JSON.parse regardless of formatting, but the anchor made the rewrite itself fragile - it hit the anchor-mismatch case on CI at least twice (2026-08-18, 2026-08-24), aborting the v1.x publish workflow with a false "no top-level version line" error. Match the fleet's own canonical scripts/fleet/bump.mts, which drops the anchor and matches the first "version": " occurrence anywhere in the manifest.
Bring writeManifestVersion to byte-for-byte parity with the fleet's
scripts/fleet/bump.mts replaceVersion: require at least one character in
the existing version (an empty version is as broken as a missing one)
and use a replacer function instead of a $1${version}$2 template, which
would mis-substitute if the derived version ever contained a literal $.
|
[agent] Follow-up commit brings writeManifestVersion to exact parity with the fleet's canonical scripts/fleet/bump.mts (replaceVersion): [^"]+ instead of [^"]* (an empty version is as broken as a missing one), and a replacer function instead of a \$1\${version}\$2 template (avoids mis-substitution if a derived version ever contained a literal $). Also worth noting while double-checking this: the canonical replaceVersion itself has no check that the replace actually matched - it can silently no-op and ship a release with the stale version still in package.json. This PR's writeManifestVersion throws loudly instead (kept intentionally, not something I'm changing to "match" canonical). Flagging as a separate, low-urgency hardening idea for the fleet script rather than folding it into this PR. Separately: this PR's own merge state is currently UNSTABLE - GitHub is waiting on e2e-tests (20, ubuntu-latest) as a required check, but the workflow only runs (22) and (24) now. That's exactly SURF-1618, live on this PR. |
Sorry, something went wrong.
|
[agent] Correction to my last comment: this PR's UNSTABLE merge state was just pending checks finishing, not a stale required check. DetailsVerified directly - v1.x has no classic branch protection and its ruleset only enforces deletion/non_fast_forward, no required status checks at all. That part of SURF-1618 was already resolved before this PR (PR #1485 merged fine). Closed the ticket. |
Sorry, something went wrong.
LLM Description written by Claude Code:Claude Sonnet 5
Summary
writeManifestVersion in scripts/release/bump.mts rewrites package.json's version field with /^(\s*"version":\s*")[^"]*(")/m - anchored to require the field to open its own line. That anchor is fragile: the v1.x publish workflow hit the mismatch on CI twice (2026-08-18, 2026-08-24), aborting the release with a false "no top-level version line" error even though JSON.parse on the exact same content resolves version correctly every time (confirmed by pulling the committed package.json at each failing run's exact commit SHA and testing the regex against it directly - it matches fine in isolation, so the anchor is failing against something in the CI-checked-out bytes that a plain git show doesn't reproduce).
The fleet's own canonical scripts/fleet/bump.mts (used by main and every other fleet member) already solves this the same way this PR does: no ^ anchor, no /m flag, just match the first "version": "..." occurrence anywhere in the file. main and other fleet repos were never at risk - only v1.x, which predates the fleet migration and still carries its own bespoke copy of this script.
Changes
Test plan
Note
Low Risk
Narrow change to release-time string replacement plus tests; no auth, runtime CLI, or user data paths.
Overview
Fixes intermittent CI release failures where writeManifestVersion falsely reported it could not find a top-level version in package.json even though JSON.parse succeeded.
The bump script now replaces the version with an unanchored regex that matches the first "version": "…" anywhere in the file, instead of requiring that pattern at the start of a line (^ + /m). That aligns with the fleet bump approach and handles minified or oddly formatted manifests that still parse as valid JSON.
Adds test/release-bump.test.mts with unit tests for pretty-printed and minified package.json, plus the error path when version is missing.
Reviewed by Cursor Bugbot for commit 09f7713. Configure here.