fix(fleet): disable typescript/no-unnecessary-type-assertion - #663
Merged
John-David Dalton (jdalton) merged 1 commit intoJul 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Cascaded from socket-wheelhouse. The type-aware pass builds scripts/**/*.mts a DEFAULT program (no strict tsconfig discoverable above scripts/), dropping noUncheckedIndexedAccess and false-flagging the fleet-mandated cached-for-loop `arr[i]!` assertions as unnecessary — reddening 🔎 Check.
John-David Dalton (jdalton)
deleted the
fix/disable-no-unnecessary-type-assertion
branch
July 24, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables typescript/no-unnecessary-type-assertion fleet-wide (cascaded from our shared template). One line in .config/fleet/oxlintrc.json.
Why
The type-aware pass (--type-aware / tsgolint) builds scripts/**/*.mts a DEFAULT program because it can't discover a strict tsconfig above scripts/. That drops noUncheckedIndexedAccess, so the fleet-mandated cached-for-loop arr[i]! assertions (required by socket/prefer-cached-for-loop + noUncheckedIndexedAccess) read as unnecessary and red 🔎 Check. Adding tsconfig files was ruled out, so the rule is turned off.
Source
The canonical entry landed in our shared fleet template config; this mirrors it. checkOxlintRuleActivations would otherwise cascade the same "off" entry on the next sync.