FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SONARPY-280 Update rule definitions for pylint 1.8 by pynicolas · Pull Request #149 · SonarSource/sonar-python · GitHub

/ sonar-python Public

SONARPY-280 Update rule definitions for pylint 1.8 - #149

Merged
pynicolas merged 8 commits into
masterfrom
pylint_rules
Apr 16, 2018
ConversationCommits (8)ChecksFiles changed
Merged

SONARPY-280 Update rule definitions for pylint 1.8#149
pynicolas merged 8 commits into
masterfrom
pylint_rules

Conversation

pynicolas commented Apr 6, 2018

Copy link
Copy Markdown
Contributor

No description provided.

pynicolas mentioned this pull request Apr 6, 2018
Closed
pynicolas changed the title Update rule definitions for pylint 1.8 SONARPY-280 Update rule definitions for pylint 1.8 Apr 13, 2018
vilchik-elena approved these changes Apr 13, 2018
View reviewed changes
Comment thread sonar-python-plugin/src/test/java/org/sonar/plugins/python/pylint/PylintRuleRepositoryTest.java Outdated
List<RulesDefinition.Rule> rules = repository.rules();
assertThat(rules).isNotNull();
assertThat(rules).hasSize(180);
assertThat(rules).hasSize(322);

vilchik-elena Apr 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@pynicolas I noticed inconsistency: we declare 322 rules, but there are 328 entries in remediation cost file.
Also while there are 142 rules added in rules.xml, there are only 116 added in rules_generated.

pynicolas Apr 13, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@vilchik-elena I fixed the first inconsistencies you noticed in d632d01. We now define 325 rules.
The second set of inconsistencies is due to the rules which were removed by pylint and which we still want to define: these rules were removed from rules_generated.xml but not from rules.xml.
Thanks!

pynicolas merged commit 277e862 into master Apr 16, 2018
pynicolas deleted the pylint_rules branch April 16, 2018 06:49

gcaill commented Apr 17, 2018

Copy link
Copy Markdown

Thanks for your response time @pynicolas ! much appreciated!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vilchik-elena vilchik-elena approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL