Add Hutool taint flows for javasecurity-advanced config demo - #87
Open
sylvain-combe-sonarsource wants to merge 1 commit into
Open
sylvain-combe-sonarsource wants to merge 1 commit into
sylvain-combe-sonarsource wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Introduce AdvancedConfigServlet with three taint vulnerabilities whose sinks (cn.hutool.* APIs) are modeled only by the javasecurity-advanced library config, not the base/Enterprise javasecurity config: - S2076 OS command injection via RuntimeUtil.exec(String...) - S2083 path traversal via FileUtil.readUtf8String(String) - S2083 path traversal via FileUtil.del(String) Source is HttpServletRequest.getParameter (base-modeled), so these issues isolate the detection value added by the advanced library config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
|
Sorry, something went wrong.
| protected void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws ServletException, IOException { | ||
| String cmd = request.getParameter("cmd"); | ||
| RuntimeUtil.exec(cmd); // advanced-only sink |
| protected void readFile(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| String path = request.getParameter("path"); | ||
| String content = FileUtil.readUtf8String(path); // advanced-only sink |
| */ | ||
| protected void deleteFile(HttpServletRequest request) { | ||
| String victim = request.getParameter("file"); | ||
| FileUtil.del(victim); // advanced-only sink |
| protected void readFile(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| String path = request.getParameter("path"); | ||
| String content = FileUtil.readUtf8String(path); // advanced-only sink |
| */ | ||
| protected void deleteFile(HttpServletRequest request) { | ||
| String victim = request.getParameter("file"); | ||
| FileUtil.del(victim); // advanced-only sink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds AdvancedConfigServlet with three taint vulnerabilities whose sinks are modeled only by the javasecurity-advanced library config — not the base/Enterprise javasecurity config.
Why
Source is HttpServletRequest.getParameter (modeled by the base config). The sinks are Hutool (cn.hutool.*) APIs that exist in javasecurity-advanced but are absent from the base config:
Isolates the detection value of the advanced library config.
Changes
Compiles clean. Vulnerabilities are intentional demo payload.
🤖 Generated with Claude Code